Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HpxSparseMap class #2564

Merged
merged 4 commits into from Nov 19, 2019
Merged

Remove HpxSparseMap class #2564

merged 4 commits into from Nov 19, 2019

Conversation

@adonath
Copy link
Member

adonath commented Nov 19, 2019

Description
This pull request removes the HpxSparseMap class from gammapy.maps and related code.
One of the main goals for Gammapy v1.0 is to arrive at a clean code base. For this reason we
decided at the Granada coding sprint to remove the partly broken and complex code supporting sparse HEALPix maps. In Gammapy there is now no use case for this data structure. If we need the support for sparse HEALPix maps in future we will re-introduce from history, but in a uniform and cleaner way.

Dear reviewer
Please merge once Travis-CI is green.

@adonath adonath self-assigned this Nov 19, 2019
@adonath adonath added this to the 0.15 milestone Nov 19, 2019
Copy link
Contributor

registerrier left a comment

Looks good. Thanks @adonath

@cdeil cdeil added the cleanup label Nov 19, 2019
@cdeil cdeil added this to To do in gammapy.maps via automation Nov 19, 2019
gammapy.maps automation moved this from To do to In progress Nov 19, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 19, 2019

Codecov Report

Merging #2564 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2564      +/-   ##
==========================================
+ Coverage   91.48%   91.48%   +<.01%     
==========================================
  Files         143      141       -2     
  Lines       16133    15934     -199     
==========================================
- Hits        14759    14578     -181     
+ Misses       1374     1356      -18
Impacted Files Coverage Δ
gammapy/maps/base.py 82.12% <ø> (+0.61%) ⬆️
gammapy/maps/__init__.py 100% <ø> (ø) ⬆️
gammapy/maps/hpxmap.py 91.66% <ø> (-0.55%) ⬇️
gammapy/maps/hpxnd.py 89.49% <0%> (-6.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec170b0...11da9b7. Read the comment docs.

@adonath adonath force-pushed the adonath:remove_sparse_hpx_map branch from 92e62a8 to 11da9b7 Nov 19, 2019
@adonath adonath merged commit fb96f4c into gammapy:master Nov 19, 2019
10 checks passed
10 checks passed
greeting
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Scrutinizer Analysis: 1 updated code elements – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
gammapy.gammapy Build #20191119.16 succeeded
Details
gammapy.gammapy (DevDocs) DevDocs succeeded
Details
gammapy.gammapy (Lint) Lint succeeded
Details
gammapy.gammapy (Test Python36) Test Python36 succeeded
Details
gammapy.gammapy (Test Windows36) Test Windows36 succeeded
Details
gammapy.gammapy (Test Windows37) Test Windows37 succeeded
Details
gammapy.maps automation moved this from In progress to Done Nov 19, 2019
@adonath adonath changed the title Remove HpxSparseMap Remove HpxSparseMap class Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
gammapy.maps
  
Done
3 participants
You can’t perform that action at this time.