Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Improve spectral model error propagation #2585
This PR changes the spectral model error propagation methods from the
The main change here is a new implementation for these methods:
A regression test for the ECPL model case, closing #2007 now.
This PR should also fix #2190 (Naima models) and #1046 (absorbed models), since the new implementation is generic. I'm not adding regression tests for those here, but I've left a TODO comment that this should be done in the future.
These custom methods are deleted here:
Work in progres ...
@adonath - Could you please finish this PR? (or comment with suggestions)
There's two unit-related remaining fails that you can reproduce with:
Probably the issue is the hard-coded
Another possible unit issue is this
Finally, this should be improved:
This can be deleted for sure:
but probably there's other improvements that can be made in that function. E.g. below the same slice is taken multiple times which is slow. If we use integrate this will be in our model fitting hot loop, no?
Finally, I removed