Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add light curve flare tutorial notebook #2594
This PR create a logbook to explain how to perform a LC on smaller bin than an observation duration.
Current version: here
@JouvinLea - Thanks!
Can you please shorten the notebook title?
See navbar on the left here. The idea is that notebook titles and section headings are a few words, and can be visible in the navbar.
Maybe "Light curves - Flare"?
Same for all the section titles, they should be very short and clear and not too many different levels (I think currently you have 4 different levels, that won't fit in the navbar).
For the time intervals, I'd suggest to write it like this, it's a little bit shorter:
time_intervals = [ ["2004-12-04T22:00", "2004-12-04T22:15"], ["2004-12-04T22:15", "2004-12-04T22:30"], ["2004-12-04T22:30", "2004-12-04T22:45"], ["2004-12-04T22:45", "2004-12-04T23:00"], ["2004-12-04T23:00", "2004-12-04T23:15"], ["2004-12-04T23:15", "2004-12-04T23:30"], ["2004-12-06T23:00", "2004-12-06T23:15"], ["2004-12-06T23:15", "2004-12-06T23:30"], ["2004-12-08T21:45", "2004-12-08T22:00"], ["2004-12-08T22:00", "2004-12-08T22:15"], ] time_intervals = [Time(_) for _ in time_intervals] print(time_intervals)
For energy axis and energy grids, I suggest we always us
The reference to
That's just superficial comments, I didn't review this notebook concerning content.
@@ Coverage Diff @@ ## master #2594 +/- ## ========================================= Coverage ? 91.49% ========================================= Files ? 140 Lines ? 15992 Branches ? 0 ========================================= Hits ? 14632 Misses ? 1360 Partials ? 0
@registerrier - When adding a tutorial notebook, you have to add it to
If we want to iterate and improve the Gammapy documentation quickly, we have to make the content visible at https://docs.gammapy.org/dev/