Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change SpectrumDataset and FluxPointDataset model to SkyModels #2595

Merged
merged 11 commits into from Nov 22, 2019

Conversation

@QRemy
Copy link
Contributor

QRemy commented Nov 22, 2019

Change 1D dataset.model from SpectralModel to SkyModel. This allows the yaml serialization to work consistently for all datasets as shown in the joint 1d/3d tutorial.

@QRemy QRemy requested a review from adonath Nov 22, 2019
QRemy added 2 commits Nov 22, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 22, 2019

Codecov Report

Merging #2595 into master will decrease coverage by <.01%.
The diff coverage is 97.7%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2595      +/-   ##
==========================================
- Coverage    91.5%   91.49%   -0.01%     
==========================================
  Files         140      140              
  Lines       15970    15992      +22     
==========================================
+ Hits        14613    14632      +19     
- Misses       1357     1360       +3
Impacted Files Coverage Δ
gammapy/time/lightcurve.py 86.81% <ø> (ø) ⬆️
gammapy/modeling/models/spectral_cosmic_ray.py 95.83% <ø> (ø) ⬆️
gammapy/time/variability.py 100% <ø> (ø) ⬆️
gammapy/irf/psf_gauss.py 77.55% <0%> (ø) ⬆️
gammapy/cube/psf_map.py 95.76% <100%> (ø) ⬆️
gammapy/data/observations.py 78% <100%> (ø) ⬆️
gammapy/modeling/models/cube.py 94.91% <100%> (+0.11%) ⬆️
gammapy/modeling/models/spectral.py 98% <100%> (ø) ⬆️
gammapy/spectrum/dataset.py 95.36% <100%> (+0.27%) ⬆️
gammapy/time/lightcurve_estimator.py 94.93% <100%> (-1.27%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fc61f6...7c4b329. Read the comment docs.

@QRemy QRemy added this to the 0.15 milestone Nov 22, 2019
@QRemy QRemy added this to In progress in gammapy.modeling via automation Nov 22, 2019
Copy link
Member

adonath left a comment

Thanks @QRemy! Looks good to me...

@adonath adonath merged commit 58230aa into gammapy:master Nov 22, 2019
7 of 10 checks passed
7 of 10 checks passed
greeting
Details
Scrutinizer Created
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
gammapy.gammapy in progress
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
gammapy.gammapy (DevDocs) DevDocs succeeded
Details
gammapy.gammapy (Lint) Lint succeeded
Details
gammapy.gammapy (Test Python36) Test Python36 succeeded
Details
gammapy.gammapy (Test Windows36) Test Windows36 succeeded
Details
gammapy.gammapy (Test Windows37) Test Windows37 succeeded
Details
gammapy.modeling automation moved this from In progress to Done Nov 22, 2019
@adonath adonath self-assigned this Nov 22, 2019
@adonath adonath changed the title Change 1D dataset model to SkyModels Change SpectrumDataset and FluxPointDataset model to SkyModels Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.