New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add offset-dependent effective area IRF class #260

Merged
merged 5 commits into from May 19, 2015

Conversation

Projects
None yet
3 participants
@joleroi
Contributor

joleroi commented May 6, 2015

basic implementation of the EffArea2D class

joleroi added some commits Apr 30, 2015

Added aeff2D class to read the HAP output file produces by hap-to-irf…
… (follows some standard)

Tested functionality so far: Get effarea vector for spectral analysis

@cdeil cdeil added the feature label May 6, 2015

@cdeil cdeil added this to the 0.3 milestone May 6, 2015

@cdeil cdeil self-assigned this May 6, 2015

hdu_list : `~astropy.io.fits.HDUList`
aeff2D file contents.
"""
filename = get_path('irfs/aeff2D.fits')

This comment has been minimized.

@cdeil

cdeil May 6, 2015

Member

Commit the example FITS file to the repo?
(It's small, right?)

@cdeil

cdeil May 6, 2015

Member

Commit the example FITS file to the repo?
(It's small, right?)

This comment has been minimized.

@joleroi

joleroi May 6, 2015

Contributor

20K, git says however
The following paths are ignored by one of your .gitignore files:
gammapy/datasets/data/irfs/aeff2D.fits
should I force it?

@joleroi

joleroi May 6, 2015

Contributor

20K, git says however
The following paths are ignored by one of your .gitignore files:
gammapy/datasets/data/irfs/aeff2D.fits
should I force it?

This comment has been minimized.

@cdeil

cdeil May 8, 2015

Member

Yes, use git add -f to add this file and fix this test error on travis-ci:
https://travis-ci.org/gammapy/gammapy/jobs/61775130#L1033

@cdeil

cdeil May 8, 2015

Member

Yes, use git add -f to add this file and fix this test error on travis-ci:
https://travis-ci.org/gammapy/gammapy/jobs/61775130#L1033

Show outdated Hide outdated gammapy/irf/effective_area_table.py Outdated
Show outdated Hide outdated gammapy/irf/effective_area_table.py Outdated
Show outdated Hide outdated gammapy/irf/effective_area_table.py Outdated
Show outdated Hide outdated gammapy/irf/effective_area_table.py Outdated

@cdeil cdeil changed the title from Effarea to Add offset-dependent effective area IRF class May 8, 2015

Show outdated Hide outdated gammapy/irf/effective_area_table.py Outdated
Show outdated Hide outdated gammapy/irf/effective_area_table.py Outdated
Show outdated Hide outdated gammapy/irf/effective_area_table.py Outdated
Show outdated Hide outdated gammapy/irf/effective_area_table.py Outdated
@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil May 8, 2015

Member

I've left a few inline comments.

FYI : The main criterion before a pull request can be merged is that the travis-ci tests pass. Otherwise the testing in master would be broken and tests in all other pull requests would fail.

Member

cdeil commented May 8, 2015

I've left a few inline comments.

FYI : The main criterion before a pull request can be merged is that the travis-ci tests pass. Otherwise the testing in master would be broken and tests in all other pull requests would fail.

joleroi added some commits May 8, 2015

Removed loop in tests -> pytest.parametrize
Unified evaluate functions to only one function self.evaluate
Adjusted plot functions
Did pep8 stuff
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls May 12, 2015

Coverage Status

Coverage increased (+0.21%) to 46.09% when pulling 3e926bc on kingj90:effarea into b56a56a on gammapy:master.

coveralls commented May 12, 2015

Coverage Status

Coverage increased (+0.21%) to 46.09% when pulling 3e926bc on kingj90:effarea into b56a56a on gammapy:master.

Show outdated Hide outdated gammapy/irf/effective_area_table.py Outdated
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls May 12, 2015

Coverage Status

Coverage increased (+0.21%) to 46.09% when pulling 81babb0 on kingj90:effarea into b56a56a on gammapy:master.

coveralls commented May 12, 2015

Coverage Status

Coverage increased (+0.21%) to 46.09% when pulling 81babb0 on kingj90:effarea into b56a56a on gammapy:master.

@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil May 13, 2015

Member

@kingj90 – Looks good to me. Should I merge this? Or was there something else you wanted to do in this PR?

Member

cdeil commented May 13, 2015

@kingj90 – Looks good to me. Should I merge this? Or was there something else you wanted to do in this PR?

@joleroi

This comment has been minimized.

Show comment
Hide comment
@joleroi

joleroi May 19, 2015

Contributor

@cdeil : Yes, please merge it, I am not planning to change anything for now. I will instead turn towards HSPEC in gammapy

Contributor

joleroi commented May 19, 2015

@cdeil : Yes, please merge it, I am not planning to change anything for now. I will instead turn towards HSPEC in gammapy

@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil May 19, 2015

Member

Thanks!

I think this is a great addition ... it's important we can process the same inputs as ctools, and it's very convenient to only have to exports IRFs once and select the FOV position later from a Python script.

Member

cdeil commented May 19, 2015

Thanks!

I think this is a great addition ... it's important we can process the same inputs as ctools, and it's very convenient to only have to exports IRFs once and select the FOV position later from a Python script.

cdeil added a commit that referenced this pull request May 19, 2015

Merge pull request #260 from kingj90/effarea
Add offset-dependent effective area IRF class

@cdeil cdeil merged commit 6c0ad10 into gammapy:master May 19, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.21%) to 46.09%
Details

@joleroi joleroi deleted the joleroi:effarea branch Jul 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment