New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spiral arm model bar radius #261

Merged
merged 1 commit into from May 8, 2015

Conversation

Projects
None yet
3 participants
@klepser
Contributor

klepser commented May 8, 2015

  • Bar extends to 3 kpc (like in all Vallee papers).
  • Change order of spiral arm names (I think this has no impact on anything, but this is where this debug all began :)
Update spatial.py
* Bar extends to 3 kpc (like in all Vallee papers).
* Change order of spiral arm names (I think this has no impact on anything, but this is where this debug all began :)
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls May 8, 2015

Coverage Status

Coverage decreased (-0.6%) to 45.88% when pulling cc3f859 on klepser:patch-1 into c4e0c4b on gammapy:master.

coveralls commented May 8, 2015

Coverage Status

Coverage decreased (-0.6%) to 45.88% when pulling cc3f859 on klepser:patch-1 into c4e0c4b on gammapy:master.

@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil May 8, 2015

Member

@klepser – Thanks and welcome to Github!

The test error on this pull request is completely unrelated
https://travis-ci.org/gammapy/gammapy/jobs/61750271#L1738
due to a change in reproject yesterday:
https://groups.google.com/forum/#!topic/astropy-dev/7SQHafA0eIU

I have to go now, I'll fix that tonight and then merge this.

Member

cdeil commented May 8, 2015

@klepser – Thanks and welcome to Github!

The test error on this pull request is completely unrelated
https://travis-ci.org/gammapy/gammapy/jobs/61750271#L1738
due to a change in reproject yesterday:
https://groups.google.com/forum/#!topic/astropy-dev/7SQHafA0eIU

I have to go now, I'll fix that tonight and then merge this.

@cdeil cdeil added the bug label May 8, 2015

@cdeil cdeil added this to the 0.3 milestone May 8, 2015

@cdeil cdeil self-assigned this May 8, 2015

@cdeil cdeil changed the title from Update spatial.py to Fix spiral arm model bar radius May 8, 2015

@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil May 8, 2015

Member

Thanks!

Member

cdeil commented May 8, 2015

Thanks!

cdeil added a commit that referenced this pull request May 8, 2015

Merge pull request #261 from klepser/patch-1
Fix spiral arm model bar radius

@cdeil cdeil merged commit b56a56a into gammapy:master May 8, 2015

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.6%) to 45.88%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment