New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SNRCat dataset access function #262

Merged
merged 1 commit into from May 19, 2015

Conversation

Projects
None yet
2 participants
@cdeil
Member

cdeil commented May 11, 2015

This PR adds the gammapy.datasets.fetch_catalog_snrcat function.

The SNR parameters were extensively checked against Green's catalog (see here) and the differences observed there will be corrected in the catalogs (all in Green's catalog I think).

Just in case the CSV version of SNRCat gets removed or changes too frequently, I've put a FITS version as of 2015-05-19 with file size 35K in gammapy/gammapy-extra@fd2f1ed generated using this command:

python -c 'from gammapy.datasets import fetch_catalog_snrcat; t = fetch_catalog_snrcat(cache=False); t.write("snrcat.fits.gz")'

@cdeil cdeil added the feature label May 11, 2015

@cdeil cdeil self-assigned this May 11, 2015

@cdeil cdeil added this to the 0.3 milestone May 11, 2015

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls May 11, 2015

Coverage Status

Coverage decreased (-0.07%) to 45.81% when pulling c726e97 on cdeil:snrcat into b56a56a on gammapy:master.

coveralls commented May 11, 2015

Coverage Status

Coverage decreased (-0.07%) to 45.81% when pulling c726e97 on cdeil:snrcat into b56a56a on gammapy:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls May 19, 2015

Coverage Status

Coverage decreased (-0.13%) to 42.13% when pulling efadafd on cdeil:snrcat into 823c443 on gammapy:master.

coveralls commented May 19, 2015

Coverage Status

Coverage decreased (-0.13%) to 42.13% when pulling efadafd on cdeil:snrcat into 823c443 on gammapy:master.

cdeil added a commit that referenced this pull request May 19, 2015

Merge pull request #262 from cdeil/snrcat
Add SNRCat dataset access function

@cdeil cdeil merged commit 07124da into gammapy:master May 19, 2015

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.13%) to 42.13%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment