Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove keepdims option from MapDataset.to_images() #2637

Merged
merged 1 commit into from Nov 29, 2019

Conversation

@adonath
Copy link
Member

adonath commented Nov 29, 2019

Description

This pull request addresses #2537., by removing the keepdims option from MapDataset.to_images(). The underlying problem is, that BackgroundModel requires am energy axis to be defined. Also in Gammapy a 2D analysis currently requires an energy bin defined. In https://docs.gammapy.org/dev/notebooks/cta_data_analysis.html#Compute-images, we show how to extract the images.

@adonath adonath self-assigned this Nov 29, 2019
@adonath adonath added the bug label Nov 29, 2019
@adonath adonath added this to the 0.15 milestone Nov 29, 2019
@adonath adonath added this to In progress in gammapy.cube via automation Nov 29, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 29, 2019

Codecov Report

Merging #2637 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2637      +/-   ##
==========================================
- Coverage   91.56%   91.56%   -0.01%     
==========================================
  Files         141      141              
  Lines       15851    15846       -5     
==========================================
- Hits        14514    14509       -5     
  Misses       1337     1337
Impacted Files Coverage Δ
gammapy/cube/exposure.py 94.73% <100%> (-1.1%) ⬇️
gammapy/cube/fit.py 89.93% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d00597a...561fd83. Read the comment docs.

@adonath adonath merged commit 9975ece into gammapy:master Nov 29, 2019
12 checks passed
12 checks passed
greeting
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Scrutinizer Analysis: No new issues – Tests: passed
Details
codecov/patch 100% of diff hit (target 91.56%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +8.43% compared to d00597a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
gammapy.gammapy #20191129.24 succeeded
Details
gammapy.gammapy (DevDocs) DevDocs succeeded
Details
gammapy.gammapy (Lint) Lint succeeded
Details
gammapy.gammapy (Test Python36) Test Python36 succeeded
Details
gammapy.gammapy (Test Windows36) Test Windows36 succeeded
Details
gammapy.gammapy (Test Windows37) Test Windows37 succeeded
Details
gammapy.cube automation moved this from In progress to Done Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
gammapy.cube
  
Done
1 participant
You can’t perform that action at this time.