Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add a simple Makefile for Gammapy. #289
referenced this pull request
Jun 13, 2015
@mapazarr - Thanks for the PR.
As I wrote here I think adding a
The only make target you define here that's not directly available via
python setup.py clean python setup.py build_sphinx --clean-docs
It's very rare that people produce coverage reports, and for those expert users I think having to run
So at the very least the info given here should be updated to mention those setup.py clean commands:
And there are things which aren't available via
(these are copied targets from the other Makefiles mentioned, they'd have to be adapted for Gammapy).
There could be other more complicated things, like building conda packages or testing that all the Gammapy example notebooks still run without error ...
So after thinking about this some more while writing this response, I do think a Makefile would be good to have for things that aren't available via setup.py. Whether it's useful to duplicate the most common functionality of
@mapazarr – I've changed my mind on this ... let's do it.
Could you please try to make the Makefile better taking my comments above into account.
One thing I like is to have a
I do not like forwarding any commands from make to setup.py ... I've tried to use this for ctapipe and I think it's too confusing when the user mistypes some command or uses one that doesn't exist:
I'll then give this a final review next week or make some tweaks and we'll include this in the 0.3 release.
There should be a changelog entry and the existence of this Makefile and a few examples / comments should be added to the Gammapy docs.