New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using consistent plotting style in docs #317

Merged
merged 1 commit into from Aug 5, 2015

Conversation

Projects
None yet
2 participants
@adonath
Member

adonath commented Aug 4, 2015

This PR changes the plotting style of all the plots in the docs to a uniform format. Additionally some of the plots were slightly improved.

@cdeil cdeil added this to the 0.3 milestone Aug 4, 2015

@cdeil cdeil self-assigned this Aug 4, 2015

@@ -17,4 +17,4 @@
plt.ylabel('radius [pc]')
plt.legend(loc=4)
plt.loglog()
plt.show()
plt.savefig('test.png')

This comment has been minimized.

@cdeil

cdeil Aug 4, 2015

Member

Why is there a savefig call here?
Does this work with the Sphinx build, i.e. get shown in the HTML output.

Otherwise, @adonath, everything looks good ... merge?

This comment has been minimized.

@adonath

adonath Aug 5, 2015

Member

Fixed

@adonath adonath force-pushed the adonath:astropy_style_docs_plots branch from 613eb20 to 5d6823c Aug 5, 2015

@adonath

This comment has been minimized.

Member

adonath commented Aug 5, 2015

Travis passed, so I think it's ready to merge...

@cdeil

This comment has been minimized.

Member

cdeil commented Aug 5, 2015

OK ... let's see if this works on readthedocs ...

cdeil added a commit that referenced this pull request Aug 5, 2015

Merge pull request #317 from adonath/astropy_style_docs_plots
Using consistent plotting style in docs

@cdeil cdeil merged commit 0c96597 into gammapy:master Aug 5, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@cdeil

This comment has been minimized.

Member

cdeil commented Aug 5, 2015

Built passed and log looks OK:
https://readthedocs.org/builds/gammapy/3199042/

Most images look OK for me locally and RTD, see e.g.
https://gammapy.readthedocs.org/en/latest/astro/source/pwn.html

@adonath – Could this be because of the set_aspect_ratio call? Can / should that be removed? Why is it different only for me?

@cdeil

This comment has been minimized.

Member

cdeil commented Aug 5, 2015

One more thing: @adonath , can you please add a one-line changelog entry for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment