New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve background model simulation #335

Merged
merged 2 commits into from Aug 21, 2015

Conversation

Projects
None yet
2 participants
@mapazarr
Member

mapazarr commented Aug 21, 2015

Revised functions to produce true bg cube models and simulated data: the models should match.
In addition, the high-level docs have been updated to include a paragraph on doing true/reco bg cube models.

@mapazarr

This comment has been minimized.

Show comment
Hide comment
@mapazarr

mapazarr Aug 21, 2015

Member

@cdeil I know this is a last minute addition, but can you merge it? At some point, the models used for simulating data and producing true models should be somehow centralized and shared between the functions. Making this another point in #333.

Member

mapazarr commented Aug 21, 2015

@cdeil I know this is a last minute addition, but can you merge it? At some point, the models used for simulating data and producing true models should be somehow centralized and shared between the functions. Making this another point in #333.

@mapazarr mapazarr referenced this pull request Aug 21, 2015

Closed

Improve cube bg model production #333

1 of 20 tasks complete

@cdeil cdeil added this to the 0.4 milestone Aug 21, 2015

@cdeil cdeil self-assigned this Aug 21, 2015

cdeil added a commit that referenced this pull request Aug 21, 2015

Merge pull request #335 from mapazarr/mod_bg_data_model
Production of true/reco bg cube models should use the same model.

@cdeil cdeil merged commit 4c3ce47 into gammapy:master Aug 21, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Aug 21, 2015

Member

Sure, no problem. The GSoC pencils down deadline doesn't really matter. Pull requests are welcome any time!

Member

cdeil commented Aug 21, 2015

Sure, no problem. The GSoC pencils down deadline doesn't really matter. Pull requests are welcome any time!

@mapazarr mapazarr changed the title from Production of true/reco bg cube models should use the same model. to Production of true/reco bg cube models should use the same model Sep 2, 2015

@cdeil cdeil changed the title from Production of true/reco bg cube models should use the same model to Improve background model simulation Sep 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment