Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PoissonLikelihoodFitter #339

Merged
merged 2 commits into from Aug 27, 2015
Merged

Conversation

@cdeil
Copy link
Member

@cdeil cdeil commented Aug 27, 2015

There have been quite a few discussions and a few attempts to make astropy.modeling a useful modeling / fitting framework for us, but they all stalled (the last one being astropy/astropy#3786 by @nden).

So now we've decided to use Sherpa for Gammapy and this PR is a first step in that direction by removing the PoissonLikelihoodFitter class that I added a few years back when astropy.modeling added fitters.

Just in case someone wants to implement a Poisson likelihood fitter in Astropy ... this was the latest version of the class in Gammapy: cdeil@8108359

@cdeil cdeil added the cleanup label Aug 27, 2015
@cdeil cdeil self-assigned this Aug 27, 2015
@cdeil cdeil added this to the 0.4 milestone Aug 27, 2015
cdeil added a commit that referenced this pull request Aug 27, 2015
Remove PoissonLikelihoodFitter
@cdeil cdeil merged commit 4238aea into gammapy:master Aug 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.