Join GitHub today
Add gammapy.region and reflected region computation #379
This PR rewrites the reflected regions algorithm in Gammapy. It is now a function in gammapy/regions/reflected.py
It continues #372
I briefly browsed through this, and the code looks good, but of course this is very superficial.
Let me know if you want me to review this or try it out tomorrow.
@cdeil : I will wrap this up today or tomorrow and then add some high level docs and examples for the tutorial over the weekend (in a separate PR, or does this have to be in the release?).
added a commit
this pull request
Nov 14, 2015
Nov 14, 2015
1 check passed
I like the random reflected region image in the docs:
I get one test error now:
The issue is that you've hardcoded an absolute path here:
I have the
Not sure how to make this work ... @kingj90 any thoughts?
@joleroi - I'd like to finally make the Gammapy 0.4 release next week and started some cleanup.
The PR description (i.e. the first comment on this issue) still has a task list with open points and the description is a bit cryptic. This happens to me also all the time ... the content and scope of PRs changes while I work on them. I think it helps a bit if the PR title and description and task list is cleaned up a bit once it's merged and the changelog entry is made. I don't mean spend a lot of time on it, just ~ 1 minute, because the fraction of people that will look at the PR in the future is small (mostly Gammapy maintainers that try to find out "why was this done this way?").
Can you please edit the description of this PR and your future PRs?
I've adapted the milestone dates on GH.
It's kind of bad how the schedule slips, but it's also normal for open-source projects, where the devs are scientists that work on this when they get a chance.