Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIG 23 - Gammapy Release Cycle and Version Numbering #3950

Merged
merged 5 commits into from Sep 9, 2022

Conversation

registerrier
Copy link
Contributor

Description

This pull request introduces a PIG on the release scheme and development workflow after v1.0

For now it is a first draft.

Dear reviewer

@registerrier registerrier marked this pull request as draft May 13, 2022 12:03
@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #3950 (5d96871) into master (89f67e3) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3950      +/-   ##
==========================================
- Coverage   94.05%   94.04%   -0.02%     
==========================================
  Files         162      162              
  Lines       21402    21438      +36     
==========================================
+ Hits        20130    20161      +31     
- Misses       1272     1277       +5     
Impacted Files Coverage Δ
gammapy/modeling/iminuit.py 92.52% <0.00%> (-1.87%) ⬇️
gammapy/maps/wcs/ndmap.py 91.12% <0.00%> (-0.44%) ⬇️
gammapy/maps/hpx/ndmap.py 92.45% <0.00%> (-0.41%) ⬇️
gammapy/data/obs_table.py 91.45% <0.00%> (-0.29%) ⬇️
gammapy/modeling/models/temporal.py 99.05% <0.00%> (-0.01%) ⬇️
gammapy/maps/wcs/geom.py 96.49% <0.00%> (ø)
gammapy/estimators/points/lightcurve.py 100.00% <0.00%> (ø)
gammapy/datasets/map.py 93.56% <0.00%> (+0.02%) ⬆️
gammapy/maps/region/ndmap.py 93.37% <0.00%> (+0.04%) ⬆️
gammapy/maps/core.py 86.55% <0.00%> (+0.07%) ⬆️
... and 6 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@adonath adonath added this to the 1.0 milestone May 13, 2022
@adonath adonath changed the title Pig version plan PIG 23 - Gammapy Release Cycle and Version Numbering May 13, 2022
@adonath adonath added this to In Progress in DOCUMENTATION via automation Jun 1, 2022
Copy link
Member

@AtreyeeS AtreyeeS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @registerrier !

  • When and how do we decide to move from 1.x to 2.0? Probably that will not happen at least in the next 2 yrs, so we have some time to think?
  • I suppose that we will have situations where the same bug fix implementation cannot be applied between 1.0.y and 1.x.y because there can be API changes. So the PRs have to be adjusted accordingly?
  • I do not know if we are sufficiently well-planned yet to propose deprecation warnings. Maybe we can try putting it, but not make it necessary by adding in the PIG?

docs/development/pigs/pig-023.rst Outdated Show resolved Hide resolved
docs/development/pigs/pig-023.rst Outdated Show resolved Hide resolved
@registerrier registerrier marked this pull request as ready for review July 1, 2022 17:08
@registerrier
Copy link
Contributor Author

  • I suppose that we will have situations where the same bug fix implementation cannot be applied between 1.0.y and 1.x.y because there can be API changes. So the PRs have to be adjusted accordingly?

Good question. I have left a question in the text, but this might not need to be explained in the PIG.
Any idea @adonath ?

  • I do not know if we are sufficiently well-planned yet to propose deprecation warnings. Maybe we can try putting it, but not make it necessary by adding in the PIG?

After the co-working week close out meeting we decided to include them.

@registerrier
Copy link
Contributor Author

This is now ready for review. Please comment! @adonath @AtreyeeS @QRemy @bkhelifi @fabiopintore @LauraOlivera @cosimoNigro and all.

AtreyeeS
AtreyeeS previously approved these changes Jul 1, 2022
Copy link
Member

@AtreyeeS AtreyeeS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @registerrier ! No further comments from my side

docs/development/pigs/pig-023.rst Show resolved Hide resolved
@contrera
Copy link
Contributor

Hi
My 2 cents.
I have read the PIG and can´t see any obvious flaw or case when this should not work, but I have little experience in managing large packages on long time scales.
It looks more difficult to handle than before, for the developers, but better for users.

José Luis

Signed-off-by: Terrier <rterrier@apc.in2p3.fr>
bkhelifi
bkhelifi previously approved these changes Sep 5, 2022
Copy link
Member

@bkhelifi bkhelifi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @registerrier. This PIG can be merged.

docs/development/pigs/pig-023.rst Outdated Show resolved Hide resolved
Signed-off-by: Terrier <rterrier@apc.in2p3.fr>
@registerrier registerrier merged commit 95dc464 into gammapy:master Sep 9, 2022
DOCUMENTATION automation moved this from In Progress to Done Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
DOCUMENTATION
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants