Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
This PR introduces a new background method to the spectral fitting utilities: OFF vectors from Background models.
The appropriate statistics in Sherpa (WStat vs. cash) is not yet available. Default stat is set to CASH
@cdeil : one question - in gammapy-extra/datasets/hess-crab4_pha I have some example PHA data. In order to use this for tests I set the reference to the RMF and ARF files in the PHA header relative to $GAMMAPY_EXTRA.
Can I in principle use gammapy-extra this way or does it only work via gammapy.datasets.gammapy-extra. If the latter is the case, I don't know how to fix this test
I've left a few inline comments.
Maybe change the PR title from "OFF vector from cube background model" to "Improve spectrum analysis" since this PR now does several important improvements?
Also this comment in the PR description is cryptic:
When using a background spectral template extracted from stacked off runs, using CASH is the right thing to do, and it's available, and you're using it. Maybe rephrase?
If you have time, please look over the coverage of the files you've worked on:
Wouldn't it be better to split the
Thank for the comments, I will go trough them today. About your general comments:
This looks related https://gist.github.com/cdeil/39e9404e91954cb67270. Suggestions?
Yes and I don't know, the background model gives non-integer couns, sherpa only understands PHA (i.e. integer counts). I am happy for any suggestions what to do
Of course this is just something I hacked together. It will go away soon!