Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add King profile PSF class #447
This PR adds a first version of the King profile PSF class:
The goal is to make this work and print useful info and plot R68 and R95 / R68 as a function of energy and offset:
added a commit
this pull request
Feb 24, 2016
Of course there you can have problems with floating point numbers, but if you restrict the info output to a certain number of digit (which makes sense anyway to provide usefull information for the user) it should be fine.
What do you think?
I think the test comparison is a nice idea.
But I think it would be better to have normal assert and assert_allclose based tests.
I don't understand your proposal. How is it different from what is currently done in
The idea of the file comparison is that it's easy to generate by just running
This is compared as string using an assert. If there is a difference, the output will tell you which number is different.
If you have to update all these number manually for 5 IRF classes + high level results, this seem quite annoying to me
I'm OK with using the info string assert where it works.
But I'm not sure it will work well for high-level results such as flux and spectral index.