Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new gammapy.cube sub-package #481

Merged
merged 5 commits into from Mar 3, 2016

Conversation

@adonath
Copy link
Member

@adonath adonath commented Mar 3, 2016

This PR introduces a gammapy.cube sub-package and moves existing code to there.

@cdeil
Copy link
Member

@cdeil cdeil commented Mar 3, 2016

👍 , looks great to me.

Maybe remove the empty cube/core.py?
If / when a need for cube/core.py or cube/utils.py arises, it can be added then.

@cdeil cdeil added this to the 0.4 milestone Mar 3, 2016
************************************

.. currentmodule:: gammapy.cube

This comment has been minimized.

@cdeil

cdeil Mar 3, 2016
Member

I meant to say: add a link to those presentations instead of putting a long description here.

This comment has been minimized.

@adonath

adonath Mar 3, 2016
Author Member

Done

Instrument exposure cube.
energy_bins : `~astropy.units.Quantity`
An array of Quantities specifying the edges of the energy band
required for the predicted counts cube.

This comment has been minimized.

@joleroi

joleroi Mar 3, 2016
Contributor

you could use gammapy.utils.energy.EnergyBounds here

@joleroi
Copy link
Contributor

@joleroi joleroi commented Mar 3, 2016

👍

@cdeil
Copy link
Member

@cdeil cdeil commented Mar 3, 2016

One issue in the docs build left:
https://travis-ci.org/gammapy/gammapy/jobs/113383264#L1598

Otherwise 👍 to merge as soon as travis-ci passes.

adonath added a commit that referenced this pull request Mar 3, 2016
@adonath adonath merged commit 8db7930 into gammapy:master Mar 3, 2016
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@cdeil cdeil changed the title Introduce gammapy.cube sub-package Add new gammapy.cube sub-package Apr 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants