Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add Sherpa cube analysis prototype #484
This PR implements basic Sherpa classes for simple cube style analysis. An example notebook how to use it, can be found here. Any suggestion how to proceed with this? @cdeil @joleroi
I'll do a quick review now (but not try out the code / review implementation details).
What about the example files produced by
Could you save them as
As you're already noted at https://github.com/gammapy/gammapy-extra/blob/master/experiments/sherpa_cube_analysis_prototype/sherpa_cube_analysis_prototype.ipynb ... it would be good if you put that code somewhere in Gammapy ... these could be accessible as properties or via methods on SpectralCube, right?
Even this could be
Can you print the model at the end of
My preference would be that you add this for now then and show the Cash stat as an example.
Concerning priorities, my suggestion would be:
Then it's less clear what should have priority, maybe like this?
Only then would I say we think about / how to expose this via a command line tool.
changed the title from
Sherpa cube analysis prototype
Add Sherpa cube analysis prototype
Mar 14, 2016
added a commit
this pull request
Mar 16, 2016
If I want to try this out, what do I do?
How about putting the equivalent of