Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Improve TS map computation performance #506
This PR includes some further performance improvements to the computation of TS maps, that have been laying around on my hard disk for a while. An interesting lesson I've learned is that on most machines
Furthermore I've added a
I don't request any feedback, I'll wait for Travis-CI to pass and then merge.
After thinking about it a bit: if the effort is not too extensive, maybe exposing this optimisation to the end-user would be nice, so that I can e.g. try it easily on Mac with clang.
For the test, you'd then either have to call the old version always, or if you do call the new version, skip that on Windows.
Appveyor tests pass ... merge if you like.
If you have time, my feedback would be:
This should give you the same speed improvement on Linux, but cleaner code, no?
I couldn't resist and read a bit at http://stackoverflow.com/questions/33809789/why-are-log2-and-log1p-so-much-faster-than-log-and-log10 ... what a complicated mess.
On my computer,
But I'll admit ... it's also fascinating and in the past I've toyed with micro-optimisations also.