New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fermi catalog spectrum evaluation and plotting #507

Merged
merged 7 commits into from Apr 11, 2016

Conversation

Projects
None yet
2 participants
@joleroi
Contributor

joleroi commented Apr 11, 2016

This PR introduces

  • Integral and differential flux points Table subclasses
  • Conversion method from int to diff (wrapper around existing functionality)
  • read_3FGL methods for both flux points classes as well as SpectrumFitResult
  • evaluate and evaluate_butterfly for SpectrumFitResult

I replaces #504

Up next

  • The same for 2FHL (this is a little bit more involved)
@joleroi

This comment has been minimized.

Show comment
Hide comment
@joleroi

joleroi Apr 11, 2016

Contributor

I will merge this if tests pass - if you want to comment, hurry up 😉

Contributor

joleroi commented Apr 11, 2016

I will merge this if tests pass - if you want to comment, hurry up 😉

@cdeil cdeil added this to the 0.4 milestone Apr 11, 2016

out = reproject_interp(input_data=self.to_image_hdu(),
output_projection=refheader, *args, **kwargs)
map = SkyMap(name=self.name, data=out[0], wcs=self.wcs, unit=self.unit,
meta=self.meta)

This comment has been minimized.

@cdeil

cdeil Apr 11, 2016

Member

This is an old change, no?
Why does it appear again in this PR?

@cdeil

cdeil Apr 11, 2016

Member

This is an old change, no?
Why does it appear again in this PR?

This comment has been minimized.

@joleroi

joleroi Apr 11, 2016

Contributor

Because I cherry picked the commit, to be able to run tests

@joleroi

joleroi Apr 11, 2016

Contributor

Because I cherry picked the commit, to be able to run tests

This comment has been minimized.

@cdeil

cdeil Apr 11, 2016

Member

Hmmm, 🍒

@cdeil

cdeil Apr 11, 2016

Member

Hmmm, 🍒

This comment has been minimized.

@joleroi

joleroi Apr 11, 2016

Contributor

😋

@joleroi

joleroi Apr 11, 2016

Contributor

😋

Show outdated Hide outdated gammapy/spectrum/results.py Outdated
Show outdated Hide outdated gammapy/spectrum/results.py Outdated
Show outdated Hide outdated gammapy/spectrum/results.py Outdated
@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Apr 11, 2016

Member

Maybe add a test that exercises the plot_butterfly method?
(no asserts for now, just to make sure it runs fine for all builds)

Member

cdeil commented Apr 11, 2016

Maybe add a test that exercises the plot_butterfly method?
(no asserts for now, just to make sure it runs fine for all builds)

@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Apr 11, 2016

Member

Ha ha ... I did manage to comment here before it went in. 😼

Member

cdeil commented Apr 11, 2016

Ha ha ... I did manage to comment here before it went in. 😼

@joleroi

This comment has been minimized.

Show comment
Hide comment
@joleroi

joleroi Apr 11, 2016

Contributor

Yes the test situation with the results module is horrible. I will add some test in a follow-up PR (already in progress)

Contributor

joleroi commented Apr 11, 2016

Yes the test situation with the results module is horrible. I will add some test in a follow-up PR (already in progress)

joleroi added some commits Apr 11, 2016

@joleroi joleroi merged commit dfeab4d into gammapy:master Apr 11, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@joleroi joleroi deleted the joleroi:flux_pointsv2 branch Apr 11, 2016

@cdeil cdeil removed the infrastructure label Apr 20, 2016

@cdeil cdeil changed the title from Add convenience methods to read 3FGL to Add Fermi catalog spectrum evaluation and plotting Apr 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment