New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and cleanup for SkyMap #518

Merged
merged 3 commits into from Apr 20, 2016

Conversation

Projects
None yet
3 participants
@adonath
Member

adonath commented Apr 20, 2016

This PR fixes a few remaining issues with the SkyMap class:

  • fix .reproject() and add a minimal test
  • fix .fill() method, allow float values and add test
  • remove duplicated and unused binning functions from EventList

@cdeil It would be great to still get this in 0.4, or is it too late?

@cdeil cdeil added the bug label Apr 20, 2016

@cdeil cdeil added this to the 0.4 milestone Apr 20, 2016

@cdeil cdeil self-assigned this Apr 20, 2016

@cdeil

This comment has been minimized.

Member

cdeil commented Apr 20, 2016

Thanks!

This can go in 0.4 ... I also still want to work on the Getting Started docs today before I make the release.

If you have more time ... I think SkyMap.plot is untested and broken. I tried using it here and got an error.

@cdeil

This comment has been minimized.

Member

cdeil commented Apr 20, 2016

There's a fail for test_spectrum on three travis-ci builds:
https://travis-ci.org/gammapy/gammapy/jobs/124414698#L1549

I don't see it locally and don't see a change in gammapy-extra that would cause it, and this is with Astropy 1.1.2. So I don't understand why this is happening.

@adonath

This comment has been minimized.

Member

adonath commented Apr 20, 2016

I'll look into it. Can I modify the crab notebook or do you have any un-comitted changes...?

@cdeil

This comment has been minimized.

Member

cdeil commented Apr 20, 2016

Can I modify the crab notebook or do you have any un-comitted changes...?

Go head, no uncommitted changes.
Lunch?

@cdeil cdeil assigned adonath and unassigned cdeil Apr 20, 2016

@adonath adonath force-pushed the adonath:fix_skymap_event_binning branch from 3d4aa9d to f873f15 Apr 20, 2016

@adonath adonath merged commit b38d9d3 into gammapy:master Apr 20, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cdeil cdeil changed the title from Fix SkyMap.reproject() and .fill() methods to Fixes and cleanup for SkyMap Apr 20, 2016

@joleroi

This comment has been minimized.

Contributor

joleroi commented Apr 20, 2016

Thanks!

@adonath adonath deleted the adonath:fix_skymap_event_binning branch Nov 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment