New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gauss PSF to_table_psf method #523

Merged
merged 2 commits into from May 2, 2016

Conversation

Projects
None yet
3 participants
@adonath
Member

adonath commented Apr 26, 2016

This PR adds a .to_table_psf() method to the EnergyDependentMultiGaussPSF class. The containment radii are tested against the analytical solution, achieving a precision of 3% for 0.5, 1, 10, 30 TeV for the chosen test dataset.

Discussing with @cdeil I realized today that the UnivariateSpline only caused problems for the computation of containment radii. I still included a small work around (aka "hack") to stabilize the spline interpolation for this case. So I could use the containment radii for the testing as well.

Here is notebook with some further minimal checks and an example how to compute the PSF in an energy band:

https://github.com/gammapy/gammapy-extra/blob/master/experiments/three_gauss_to_table_psf.ipynb

@leajouvin @cdeil

@cdeil cdeil added the feature label Apr 27, 2016

@cdeil cdeil added this to the 0.5 milestone Apr 27, 2016

@cdeil cdeil self-assigned this Apr 27, 2016

Show outdated Hide outdated gammapy/irf/psf_analytical.py Outdated
Show outdated Hide outdated gammapy/irf/psf_analytical.py Outdated
Show outdated Hide outdated gammapy/irf/psf_analytical.py Outdated

@adonath adonath merged commit 416dfcd into gammapy:master May 2, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cdeil cdeil changed the title from Add .to_table_psf() method to EnergyDependentMultiGaussPSF to Add Gauss PSF to_table_psf method May 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment