Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data_summary method to DataStore #529

Merged
merged 6 commits into from May 10, 2016
Merged

Add data_summary method to DataStore #529

merged 6 commits into from May 10, 2016

Conversation

@joleroi
Copy link
Contributor

@joleroi joleroi commented May 10, 2016

This adresses

gammasky/HESS-DL3-DR1#11

It replaces #528. Sorry I was not aware, that you cannot re-open a closed PR.

@joleroi joleroi self-assigned this May 10, 2016
@joleroi joleroi added the feature label May 10, 2016
@joleroi joleroi added this to the 0.5 milestone May 10, 2016
@joleroi
Copy link
Contributor Author

@joleroi joleroi commented May 10, 2016

@cdeil
This sounds like you 😄
https://github.com/joleroi/gammapy/blob/ds_summary/gammapy/data/data_store.py#L147

I think it is very useful to have when working with YAML config files where either a DataStore name or a directory should be valid as key.

joleroi added 2 commits May 10, 2016
@cdeil
Copy link
Member

@cdeil cdeil commented May 10, 2016

Yes, I left that comment. Feel free to remove it.

I don't have time to review the code.
Just one quick comment: add an assert or two in the test on the result table content?

joleroi added 2 commits May 10, 2016
@joleroi
Copy link
Contributor Author

@joleroi joleroi commented May 10, 2016

I will merge if tests pass

@joleroi joleroi merged commit dc603f0 into gammapy:master May 10, 2016
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@joleroi joleroi deleted the joleroi:ds_summary branch May 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.