Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spectrum and flux points to HGPS catalog #535

merged 5 commits into from May 23, 2016


Copy link

@adonath adonath commented May 20, 2016

This PR adds spectra and flux points to the SourceCatalogObjectHGPS as well as __str__ for the spectrum results.

@cdeil cdeil added the feature label May 22, 2016
@cdeil cdeil added this to the 0.5 milestone May 22, 2016
@cdeil cdeil self-assigned this May 22, 2016
Copy link

@cdeil cdeil commented May 22, 2016

I don't think docs on HGPS are appropriate at this point, but a test exercising this would be great.
Also - we should write units to the HGPS catalog and have them read from FITS here, i.e. not hard-code and duplicate them here in the reader.

@adonath adonath force-pushed the adonath:add_hgps_spectrum_code branch from 8868362 to 36e7a92 May 23, 2016
@adonath adonath merged commit 64a680c into gammapy:master May 23, 2016
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
continuous-integration/travis-ci/pr The Travis CI build is in progress
@cdeil cdeil changed the title WIP: Add spectrum and flux points to SourceCatalogObjectHGPS Add spectrum and flux points to HGPS catalog May 23, 2016
@adonath adonath deleted the adonath:add_hgps_spectrum_code branch Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants