New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spectrum and flux points to HGPS catalog #535

Merged
merged 5 commits into from May 23, 2016

Conversation

Projects
None yet
2 participants
@adonath
Member

adonath commented May 20, 2016

This PR adds spectra and flux points to the SourceCatalogObjectHGPS as well as __str__ for the spectrum results.

@cdeil cdeil added the feature label May 22, 2016

@cdeil cdeil added this to the 0.5 milestone May 22, 2016

@cdeil cdeil self-assigned this May 22, 2016

@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil May 22, 2016

Member

👍
I don't think docs on HGPS are appropriate at this point, but a test exercising this would be great.
Also - we should write units to the HGPS catalog and have them read from FITS here, i.e. not hard-code and duplicate them here in the reader.

Member

cdeil commented May 22, 2016

👍
I don't think docs on HGPS are appropriate at this point, but a test exercising this would be great.
Also - we should write units to the HGPS catalog and have them read from FITS here, i.e. not hard-code and duplicate them here in the reader.

@adonath adonath merged commit 64a680c into gammapy:master May 23, 2016

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@cdeil cdeil changed the title from WIP: Add spectrum and flux points to SourceCatalogObjectHGPS to Add spectrum and flux points to HGPS catalog May 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment