Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor effective area IRFs to use NDDataArray #541

Merged
merged 8 commits into from Jun 1, 2016
Merged

Conversation

@joleroi
Copy link
Contributor

@joleroi joleroi commented May 30, 2016

This PR replaces the old effective area classes in gammapy.irf with new ones based on ~gammapy.utils.nddata.NDDataArray.

@joleroi joleroi added this to the 0.5 milestone May 30, 2016
@joleroi joleroi changed the title Replace EffectiveAreaTable2d and EffectiveAreaTable WIP: Replace EffectiveAreaTable2d and EffectiveAreaTable May 30, 2016
@joleroi joleroi force-pushed the joleroi:aeff_new branch from db86b8b to 08a0bce May 31, 2016
@joleroi joleroi changed the title WIP: Replace EffectiveAreaTable2d and EffectiveAreaTable Replace gammapy.irf.effective_area May 31, 2016
@joleroi joleroi force-pushed the joleroi:aeff_new branch from 08a0bce to 38989fa May 31, 2016
@joleroi
Copy link
Contributor Author

@joleroi joleroi commented Jun 1, 2016

I fixed all test to make sure there's no functionality lost. OK to merge?

@cdeil
Copy link
Member

@cdeil cdeil commented Jun 1, 2016

I fixed all test to make sure there's no functionality lost. OK to merge?

Yes, for me it's OK to put this in without code review if things still work, i.e. tests pass.
I'll try to find time to have a look at your IRF refactor some day ...

@cdeil cdeil changed the title Replace gammapy.irf.effective_area Refactor effective area IRFs to use NDDataArray Jun 1, 2016
@joleroi joleroi merged commit 5990fcd into gammapy:master Jun 1, 2016
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@joleroi joleroi deleted the joleroi:aeff_new branch Jun 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants