New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add astropy.regions to gammapy.extern #547

Merged
merged 3 commits into from Jun 3, 2016

Conversation

Projects
None yet
2 participants
@joleroi
Contributor

joleroi commented Jun 3, 2016

astropy.regions is an in-development astropy affiliated package
https://github.com/astropy/regions

We want to use it in gammapy already now and therefore bundle it in gammapy.extern

The command to copy the relevant files from the regions repo is

find ./regions/* -name '*.py' |  \
grep -v 'tests' | grep -v 'conftest' |  \
grep -v '_astropy_init' | grep -v 'version.py' |  \
grep -v 'regions/io/setup_package.py'  | \ 
xargs -I {} cp -vr --parents {} ~/Software/gammapy/gammapy/extern/

as a second step gammapy/extern/regions/__init__.py was modified to this content

# Licensed under a 3-clause BSD style license - see LICENSE.rst

"""
This is an experimental package for representing regions
"""
from . import io
from . import shapes
from . import core

So to simply update

find ./regions/* -name '*.py' |  \
grep -v 'tests' | grep -v 'conftest' |  \
grep -v '_astropy_init' | grep -v 'version.py' |  \
grep -v 'regions/__init__.py' | \
grep -v 'setup_package.py'  | \
xargs -I {} cp -vr --parents {} ~/code/gammapy/gammapy/extern/

@joleroi joleroi added the astropy label Jun 3, 2016

@joleroi joleroi added this to the 0.5 milestone Jun 3, 2016

@joleroi

This comment has been minimized.

Contributor

joleroi commented Jun 3, 2016

Note: The update of all imports in gammapy will be done in #546

@cdeil cdeil added the infrastructure label Jun 3, 2016

@cdeil cdeil self-assigned this Jun 3, 2016

joleroi added some commits Jun 3, 2016

@cdeil cdeil merged commit 027514f into gammapy:master Jun 3, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@joleroi joleroi referenced this pull request Jun 24, 2016

Merged

Finish change to use gammapy.extern.regions #558

4 of 4 tasks complete

@cdeil cdeil referenced this pull request Jul 26, 2016

Merged

Change to astropy regions package #649

3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment