Add spectrum point source containment correction option #557
Conversation
registerrier
force-pushed the
registerrier:psf_arf_correction
branch
from
408427d
to
9f2a4d7
|
@joleroi - Ready to merge? |
| @@ -10,6 +10,10 @@ | |||
| from ...utils.testing import requires_dependency, requires_data, SHERPA_LT_4_8 | |||
| from astropy.utils.compat import NUMPY_LT_1_9 | |||
|
|
|||
|
|
|||
| #TODO : PHACount should not expect a BIN_LO and BIN_HI columns | |||
| #https://travis-ci.org/gammapy/gammapy/jobs/136170992#L939 | |||
cdeil
Jun 9, 2016
Member
Tests on travis-ci passed. @registerrier wants to start new work that partly builds on this pull request.
So the easiest would be to merge this PR now, if that's OK with you @joleroi ?
The main concern I have is that this PR adds an xfail to test_spectral_fit which I know you've been working on.
Maybe this has to wait a bit and then the xfail has to be removed here before it should go in?
Tests on travis-ci passed. @registerrier wants to start new work that partly builds on this pull request.
So the easiest would be to merge this PR now, if that's OK with you @joleroi ?
The main concern I have is that this PR adds an xfail to test_spectral_fit which I know you've been working on.
Maybe this has to wait a bit and then the xfail has to be removed here before it should go in?
joleroi
Jun 9, 2016
Contributor
No thats's fine. OK to merge. I will fix the test that had to be marked as xfail.
No thats's fine. OK to merge. I will fix the test that had to be marked as xfail.
|
Merging this now ... |
cdeil
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Note that the psftable.integral is returning errors at several energies because of interpolation issues. This is solved by introducing a try/except and putting nan in the corrected arf. This results is some missing values in the arf.
Also removed the column bin_lo and bin_hi in the PHA file because they introduce some mess in sherpa