Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spectrum point source containment correction option #557

Merged
merged 5 commits into from Jun 9, 2016

Conversation

@registerrier
Copy link
Contributor

@registerrier registerrier commented Jun 8, 2016

Note that the psftable.integral is returning errors at several energies because of interpolation issues. This is solved by introducing a try/except and putting nan in the corrected arf. This results is some missing values in the arf.

Also removed the column bin_lo and bin_hi in the PHA file because they introduce some mess in sherpa

@cdeil cdeil added the feature label Jun 8, 2016
@cdeil cdeil added this to the 0.5 milestone Jun 8, 2016
@registerrier registerrier force-pushed the registerrier:psf_arf_correction branch from 408427d to 9f2a4d7 Jun 9, 2016
@cdeil
Copy link
Member

@cdeil cdeil commented Jun 9, 2016

@joleroi - Ready to merge?

@@ -10,6 +10,10 @@
from ...utils.testing import requires_dependency, requires_data, SHERPA_LT_4_8
from astropy.utils.compat import NUMPY_LT_1_9


#TODO : PHACount should not expect a BIN_LO and BIN_HI columns
#https://travis-ci.org/gammapy/gammapy/jobs/136170992#L939

This comment has been minimized.

@cdeil

cdeil Jun 9, 2016
Member

Tests on travis-ci passed. @registerrier wants to start new work that partly builds on this pull request.
So the easiest would be to merge this PR now, if that's OK with you @joleroi ?
The main concern I have is that this PR adds an xfail to test_spectral_fit which I know you've been working on.
Maybe this has to wait a bit and then the xfail has to be removed here before it should go in?

This comment has been minimized.

@joleroi

joleroi Jun 9, 2016
Contributor

No thats's fine. OK to merge. I will fix the test that had to be marked as xfail.

@cdeil cdeil merged commit d2a1120 into gammapy:master Jun 9, 2016
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@cdeil
Copy link
Member

@cdeil cdeil commented Jun 9, 2016

Merging this now ...
Thanks, @registerrier!

@cdeil cdeil changed the title Addition of point source containment correction for spectrum Add spectrum point source containment correction option Jun 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants