Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd spectrum point source containment correction option #557
Conversation
cdeil
added
the
feature
label
Jun 8, 2016
cdeil
added this to the 0.5 milestone
Jun 8, 2016
cdeil
assigned
joleroi
Jun 8, 2016
registerrier
added some commits
Jun 8, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
@joleroi - Ready to merge? |
cdeil
reviewed
Jun 9, 2016
| @@ -10,6 +10,10 @@ | ||
| from ...utils.testing import requires_dependency, requires_data, SHERPA_LT_4_8 | ||
| from astropy.utils.compat import NUMPY_LT_1_9 | ||
| #TODO : PHACount should not expect a BIN_LO and BIN_HI columns | ||
| #https://travis-ci.org/gammapy/gammapy/jobs/136170992#L939 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
cdeil
Jun 9, 2016
Member
Tests on travis-ci passed. @registerrier wants to start new work that partly builds on this pull request.
So the easiest would be to merge this PR now, if that's OK with you @joleroi ?
The main concern I have is that this PR adds an xfail to test_spectral_fit which I know you've been working on.
Maybe this has to wait a bit and then the xfail has to be removed here before it should go in?
cdeil
Jun 9, 2016
Member
Tests on travis-ci passed. @registerrier wants to start new work that partly builds on this pull request.
So the easiest would be to merge this PR now, if that's OK with you @joleroi ?
The main concern I have is that this PR adds an xfail to test_spectral_fit which I know you've been working on.
Maybe this has to wait a bit and then the xfail has to be removed here before it should go in?
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
joleroi
Jun 9, 2016
Contributor
No thats's fine. OK to merge. I will fix the test that had to be marked as xfail.
joleroi
Jun 9, 2016
Contributor
No thats's fine. OK to merge. I will fix the test that had to be marked as xfail.
cdeil
merged commit d2a1120
into
gammapy:master
Jun 9, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Merging this now ... |
registerrier commentedJun 8, 2016
Note that the psftable.integral is returning errors at several energies because of interpolation issues. This is solved by introducing a try/except and putting nan in the corrected arf. This results is some missing values in the arf.
Also removed the column bin_lo and bin_hi in the PHA file because they introduce some mess in sherpa