Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish change to use gammapy.extern.regions #558

Merged
merged 12 commits into from Jun 26, 2016
Merged

Conversation

@joleroi
Copy link
Contributor

@joleroi joleroi commented Jun 8, 2016

This PR finishes the change to use gammapy.extern.regions, which is a bundled copy (added in #547) of the code that's being developed here: https://github.com/astropy/regions

Gammapy imports for regions were already updated partially in #546 to point to gammapy/extern/regions.

  • Remove gammapy/regions and docs/regions
  • Update bundled copy of gammapy/extern/regions following the instructions in #547
  • Adapt imports and docstrings for regions
  • Adapt calling code to new API to make all tests pass.
@joleroi joleroi added the cleanup label Jun 8, 2016
@joleroi joleroi added this to the 0.5 milestone Jun 8, 2016
@joleroi joleroi self-assigned this Jun 8, 2016
@cdeil cdeil self-assigned this Jun 24, 2016
@cdeil cdeil force-pushed the joleroi:regions branch from 0b16782 to 0fa4b4b Jun 24, 2016
@cdeil cdeil changed the title Remove gammapy.regions Finish change to use gammapy.extern.regions Jun 24, 2016
@cdeil cdeil mentioned this pull request Jun 24, 2016
3 tasks
@cdeil cdeil force-pushed the joleroi:regions branch from 3be5e4c to a23b2a5 Jun 26, 2016
@cdeil
Copy link
Member

@cdeil cdeil commented Jun 26, 2016

I'm merging this now. The diff is already very hard to read and I think the better solution is to make regions release and remove the bundled version soon (see astropy/regions#48).

Once that's available it will be easier to e.g. add some high-level docs on regions in the Gammapy docs, mentioning the other package and putting it as an optional dependency in setup.py.

@cdeil cdeil merged commit 7eeb7f2 into gammapy:master Jun 26, 2016
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@cdeil cdeil mentioned this pull request Jul 26, 2016
3 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants