New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add paste, cutout and look_up methods to SkyMap class #559

Merged
merged 10 commits into from Jun 10, 2016

Conversation

Projects
None yet
2 participants
@adonath
Member

adonath commented Jun 8, 2016

This PR adds cutout(), paste() and lookup_max() methods to the SkyMap class and removes it from gammapy.image.utils

@cdeil cdeil added this to the 0.5 milestone Jun 9, 2016

@cdeil cdeil self-assigned this Jun 9, 2016

Show outdated Hide outdated docs/image/skymaps.rst Outdated
Show outdated Hide outdated docs/image/skymaps.rst Outdated
Show outdated Hide outdated docs/image/skymaps.rst Outdated
Show outdated Hide outdated gammapy/image/maps.py Outdated
Show outdated Hide outdated gammapy/image/maps.py Outdated
Show outdated Hide outdated gammapy/image/maps.py Outdated
Show outdated Hide outdated gammapy/image/maps.py Outdated
Show outdated Hide outdated gammapy/image/mask.py Outdated
Show outdated Hide outdated gammapy/image/tests/test_maps.py Outdated
Show outdated Hide outdated gammapy/image/tests/test_maps.py Outdated
@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Jun 9, 2016

Member

I've left some inline comments ... all minor stuff I think.
I didn't think through the critical code like the int rounding.
For me it's OK if you just go ahead and merge this, or, if you want me to review this before we merge, let me know.

Member

cdeil commented Jun 9, 2016

I've left some inline comments ... all minor stuff I think.
I didn't think through the critical code like the int rounding.
For me it's OK if you just go ahead and merge this, or, if you want me to review this before we merge, let me know.

@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Jun 10, 2016

Member

Looks great!
Merging this now.

Member

cdeil commented Jun 10, 2016

Looks great!
Merging this now.

@cdeil cdeil merged commit 1b0671f into gammapy:master Jun 10, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment