Thanks for the pull request.
Please add / change the following things in this pull request:
# Licensed under a 3-clause BSD style license - see LICENSE.rst from __future__ import absolute_import, division, print_function, unicode_literals __all__ = [ 'exptest_for_run2', ]
As discussed in person today, the test should be replaced with this:
I.e. it must be in a function where the name starts with
Let me know when I should have a look again or if you have any examples!
@helen-poon - I left some inline comments.
If you look at #565 and scroll to the bottom, you'll see the message "This branch has conflicts that must be resolved. Use the command line to resolve conflicts before continuing.".
The merge conflict is probably in
So what you should do here to resolve the merge conflict is to rebase on trunk as described here:
If you want to try by yourself, go ahead.
I'll look at the implementation of the
And can you please clean up the code formatting in the
@helen-poon - Thank you!
I've merges this PR just now, including the improvements we did together for the example: 55c7136
I don't have time to finish rewriting
I've added you to the Gammapy contributors list here:
And this PR is listed in the changelog here: