Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Add detection utilities à la BgStats #569
Hi @cdeil ,
Maybe we could find some time do discuss this tomorrow via slack or Skype ?
There's two test fails on travis-ci:
Fixing those is the most important part so that this pull request can go in.
I see that you've implemented one version of
I'm not sure if that is the best place for this code ... naively I would have expected methods
But this PR is already 500 lines and hard for me to review, so I'm happy to merge as soon as tests pass and you think it's ready @jjlk , and then I'll use it for a bit (e.g. for the data release scripts) and then can give better feedback.
Thank you for this!
@jjlk - I've done some minor cleanup in
One more thing that PyCharm pointed out to me when I browsed your code locally is that the