New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gammapy/hspec #593

Merged
merged 2 commits into from Jun 29, 2016

Conversation

Projects
None yet
3 participants
@cdeil
Member

cdeil commented Jun 27, 2016

This PR removes gammapy/hspec.

As I mentioned in #265 (comment), the idea of adding gammapy.hspec was to have a starting point for working WSTAT analysis and integrate it with gammapy.spectrum.
This integration hasn't happened, and WSTAT is now available in Sherpa directly (although it has to be tested) and observation handling / stacking has been implemented independently of gammapy.hspec in gammapy.spectrum.

For future reference, if someone wants to add back features from gammapy.hspec (with tests and docs), that would be very welcome and the code will forever be available in the git repo, e.g. here:
https://github.com/gammapy/gammapy/tree/v0.4/gammapy/hspec

@joleroi @registerrier - Are you OK with this?

@cdeil cdeil added the cleanup label Jun 27, 2016

@cdeil cdeil added this to the 0.5 milestone Jun 27, 2016

@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Jun 27, 2016

Member

I see these mentions of hspec:

$ ack hspec
...
gammapy/spectrum/spectrum_fit.py
268:        if method == 'hspec':
269:            self._run_hspec_fit()

gammapy/spectrum/spectrum_results.py
17:- [ ] Interface these classes to Sherpa results ... make it easy to compare, i.e. cross-check `hspec` against `FitSpectrum`

I'm removing those now.

@joleroi @registerrier - Please speak up if this is working functionality and if you're using it. If yes, we should at least preserve a test with a WSTAT computed with hspec.

Member

cdeil commented Jun 27, 2016

I see these mentions of hspec:

$ ack hspec
...
gammapy/spectrum/spectrum_fit.py
268:        if method == 'hspec':
269:            self._run_hspec_fit()

gammapy/spectrum/spectrum_results.py
17:- [ ] Interface these classes to Sherpa results ... make it easy to compare, i.e. cross-check `hspec` against `FitSpectrum`

I'm removing those now.

@joleroi @registerrier - Please speak up if this is working functionality and if you're using it. If yes, we should at least preserve a test with a WSTAT computed with hspec.

@joleroi

This comment has been minimized.

Show comment
Hide comment
@joleroi

joleroi Jun 28, 2016

Contributor

the mention in gammapy/spectrum/spectrum_fit.py is removed in #592

the other file gammapy/spectrum/spectrum_results.py is not used anywhere. It is as 1 to 1 map to the HAP fitspectrum JSON output.

Contributor

joleroi commented Jun 28, 2016

the mention in gammapy/spectrum/spectrum_fit.py is removed in #592

the other file gammapy/spectrum/spectrum_results.py is not used anywhere. It is as 1 to 1 map to the HAP fitspectrum JSON output.

@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Jun 29, 2016

Member

I'm merging this now.

@registerrier - If you have any comments, let us know ... we can always revert something if useful.

Member

cdeil commented Jun 29, 2016

I'm merging this now.

@registerrier - If you have any comments, let us know ... we can always revert something if useful.

@cdeil cdeil merged commit 6015d9d into gammapy:master Jun 29, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cdeil cdeil referenced this pull request Jul 7, 2016

Closed

Integrate hspec in Gammapy #265

2 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment