Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flux points computation methods #628

Merged
merged 5 commits into from Jul 15, 2016
Merged

Add flux points computation methods #628

merged 5 commits into from Jul 15, 2016

Conversation

@joleroi
Copy link
Contributor

@joleroi joleroi commented Jul 14, 2016

This PR

  • removes to/from sherpa methods from model base class as discussed in #627
  • Adds possibility to fit model with fixed index
  • Adds script to compute flux points
  • Add model_with_uncertainties property to SpectrumResult to evaluate/plot butterlflies
@joleroi joleroi force-pushed the joleroi:fluxpoints branch from 5e0c079 to eacf392 Jul 14, 2016
@joleroi joleroi added this to the 0.5 milestone Jul 14, 2016
@joleroi
Copy link
Contributor Author

@joleroi joleroi commented Jul 14, 2016

This is the output of examples/examples_calculate_fluxpoints.py

figure_1

I won't have time to refactor this now. But I think its a good starting points for discussion.

@joleroi joleroi force-pushed the joleroi:fluxpoints branch from eacf392 to 9f064eb Jul 14, 2016
@joleroi joleroi changed the title WIP: Add flux points computation methods Add flux points computation methods Jul 14, 2016
@joleroi joleroi force-pushed the joleroi:fluxpoints branch from 9f064eb to 13d19a5 Jul 14, 2016
@cdeil
Copy link
Member

@cdeil cdeil commented Jul 14, 2016

🎉

@joleroi joleroi merged commit a62b2fc into gammapy:master Jul 15, 2016
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@joleroi joleroi deleted the joleroi:fluxpoints branch Jul 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants