New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ExclusionMask.distance #631

Merged
merged 2 commits into from Jul 20, 2016

Conversation

Projects
None yet
3 participants
@OlgaVorokh
Member

OlgaVorokh commented Jul 16, 2016

@cdeil I create this PR based on this issue.

According your comment in the issue I should do this things in the PR:

  • Start by adding a test to reproduce the issue.
  • Then move the code from the standalone function here inside the ExclusionMask.distance_image method.
  • Investigate and fix the issue ... maybe a manual change in dtype is needed to get it to work?
@OlgaVorokh

This comment has been minimized.

Show comment
Hide comment
@OlgaVorokh

OlgaVorokh Jul 17, 2016

Member

@cdeil Can you review this?

Member

OlgaVorokh commented Jul 17, 2016

@cdeil Can you review this?

@cdeil cdeil added bug cleanup labels Jul 18, 2016

@cdeil cdeil added this to the 0.5 milestone Jul 18, 2016

@cdeil cdeil self-assigned this Jul 18, 2016

@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Jul 18, 2016

Member

https://travis-ci.org/gammapy/gammapy/jobs/145330433#L1509
You need to add a @requires_dependency('scipy') to this test.

Member

cdeil commented Jul 18, 2016

https://travis-ci.org/gammapy/gammapy/jobs/145330433#L1509
You need to add a @requires_dependency('scipy') to this test.

@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Jul 18, 2016

Member

Please update the task list of this PR.
I often replace task lists with a description "This PR does ..." once it's ready for final review or to be merged.

Member

cdeil commented Jul 18, 2016

Please update the task list of this PR.
I often replace task lists with a description "This PR does ..." once it's ready for final review or to be merged.

Show outdated Hide outdated gammapy/image/mask.py Outdated
Show outdated Hide outdated gammapy/image/tests/test_mask.py Outdated
@OlgaVorokh

This comment has been minimized.

Show comment
Hide comment
@OlgaVorokh

OlgaVorokh Jul 19, 2016

Member

@cdeil Can you review this?

Member

OlgaVorokh commented Jul 19, 2016

@cdeil Can you review this?

Show outdated Hide outdated gammapy/image/mask.py Outdated
Show outdated Hide outdated gammapy/image/mask.py Outdated
Show outdated Hide outdated gammapy/image/mask.py Outdated
Show outdated Hide outdated gammapy/image/tests/test_mask.py Outdated
Show outdated Hide outdated gammapy/image/tests/test_mask.py Outdated
Show outdated Hide outdated gammapy/image/tests/test_mask.py Outdated
Show outdated Hide outdated gammapy/image/tests/test_mask.py Outdated
Show outdated Hide outdated gammapy/image/tests/test_mask.py Outdated

OlgaVorokh added some commits Jul 16, 2016

Move standalone exclusion_distance function to ExclusionMaks.distance…
…_image, add test for ExclusionMask.distance_image
Change return object of ExclusionMask.distance_image method, change t…
…ests for it, add two exceprional situations in method and fix the docs
@OlgaVorokh

This comment has been minimized.

Show comment
Hide comment
@OlgaVorokh

OlgaVorokh Jul 20, 2016

Member

@cdeil Can you review this?

Member

OlgaVorokh commented Jul 20, 2016

@cdeil Can you review this?

@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Jul 20, 2016

Member

Perfect. Thanks!

Member

cdeil commented Jul 20, 2016

Perfect. Thanks!

@cdeil cdeil merged commit f3398d1 into gammapy:master Jul 20, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cdeil cdeil referenced this pull request Jul 27, 2016

Closed

Issues with ExclusionMask.distance #587

0 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment