Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pyfact #640

Merged
merged 1 commit into from Jul 21, 2016
Merged

Remove pyfact #640

merged 1 commit into from Jul 21, 2016

Conversation

@cdeil
Copy link
Member

@cdeil cdeil commented Jul 21, 2016

This PR removes pyfact.
The idea was to refactor this to become part of Gammapy (see #78).
This hasn't happened, and we've re-built most parts in a better way. so I'm removing it now.

Note for @joleroi - There's some old spaghetti code to simulate event lists for spectra in sim_evlist. That might be functionality worth re-implementing.
Note for @adonath and me - There was an example how to make images and fit them with Sherpa. Having that in Gammapy soon is important (there are other open issues on this though).

@cdeil cdeil added the cleanup label Jul 21, 2016
@cdeil cdeil added this to the 0.5 milestone Jul 21, 2016
@cdeil cdeil self-assigned this Jul 21, 2016
@cdeil cdeil merged commit a5c1cf6 into gammapy:master Jul 21, 2016
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@cdeil cdeil mentioned this pull request Jul 21, 2016
2 of 10 tasks complete
@joleroi
Copy link
Contributor

@joleroi joleroi commented Jul 25, 2016

Looks like pyfact has everything we need. 👍 for reverting this PR and instead delete gammapy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.