New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to astropy regions package #649

Merged
merged 7 commits into from Jul 26, 2016

Conversation

Projects
None yet
3 participants
@cdeil
Member

cdeil commented Jul 26, 2016

This PR

  • Adds a dependency on the https://github.com/astropy/regions package.
  • Removes the bundled version in gammapy/extern/regions
  • Removes the use of pyregion (except for one case where a TODO was left)

Related: #336 #547 #558

@cdeil cdeil added this to the 0.5 milestone Jul 26, 2016

@cdeil cdeil self-assigned this Jul 26, 2016

@joleroi

This comment has been minimized.

Show comment
Hide comment
@joleroi

joleroi Jul 26, 2016

Contributor

🎆

Contributor

joleroi commented Jul 26, 2016

🎆

@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Jul 26, 2016

Member

@bsipocz @mwcraig - Today Gammapy builds are failing with issue like this one about astropy channel conda packages:

Error: HTTPError: 404 Client Error: NOT FOUND for url: https://conda.anaconda.org/astropy/linux-64/aplpy-1.0-py27_0.tar.bz2: https://conda.anaconda.org/astropy/linux-64/aplpy-1.0-py27_0.tar.bz2

https://travis-ci.org/gammapy/gammapy/jobs/147488386#L584

Is it useful to mention this to you or are you aware already?

Member

cdeil commented Jul 26, 2016

@bsipocz @mwcraig - Today Gammapy builds are failing with issue like this one about astropy channel conda packages:

Error: HTTPError: 404 Client Error: NOT FOUND for url: https://conda.anaconda.org/astropy/linux-64/aplpy-1.0-py27_0.tar.bz2: https://conda.anaconda.org/astropy/linux-64/aplpy-1.0-py27_0.tar.bz2

https://travis-ci.org/gammapy/gammapy/jobs/147488386#L584

Is it useful to mention this to you or are you aware already?

@mwcraig

This comment has been minimized.

Show comment
Hide comment
@mwcraig

mwcraig Jul 26, 2016

Contributor

Thanks, working on it...

Contributor

mwcraig commented Jul 26, 2016

Thanks, working on it...

@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Jul 26, 2016

Member

travis-ci and appveyor tests passed.
merging this now.

@joleroi @adonath @OlgaVorokh @jjlk - regions is now a required dependency of Gammapy for the coming months, until it gets merged into the Astropy core, you will have to install it.

We still need to add docs and integrate PixCoord and regions this with SkyImage and other parts of Gammapy in the coming weeks in other PRs ...

Member

cdeil commented Jul 26, 2016

travis-ci and appveyor tests passed.
merging this now.

@joleroi @adonath @OlgaVorokh @jjlk - regions is now a required dependency of Gammapy for the coming months, until it gets merged into the Astropy core, you will have to install it.

We still need to add docs and integrate PixCoord and regions this with SkyImage and other parts of Gammapy in the coming weeks in other PRs ...

@cdeil cdeil merged commit a66a12f into gammapy:master Jul 26, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment