New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add model image and image measurement functionality #65

Merged
merged 1 commit into from Jan 29, 2014

Conversation

Projects
None yet
2 participants
@adonath
Member

adonath commented Jan 29, 2014

Model image creation class

@cdeil

This comment has been minimized.

Member

cdeil commented Jan 29, 2014

@adonath Do you want to fix this?
https://travis-ci.org/gammapy/gammapy/jobs/17865249#L508

Or should I merge and fix it?

import numpy as np
from astropy.io import fits
from ...utils.const import fwhm_to_sigma

This comment has been minimized.

@cdeil

cdeil Jan 29, 2014

Member

I think (untested) it should be:

from ..utils.const import fwhm_to_sigma
flux_factor : float (default 1E-12)
Flux conversion factor.
Example

This comment has been minimized.

@cdeil

cdeil Jan 29, 2014

Member

I think it has to be Examples, not Example.

-------
Here is an example how to use `ModelImageCreator`:
>>> model_image_creator = MorphModelImageCreator('input_sherpa.cfg',

This comment has been minimized.

@cdeil

cdeil Jan 29, 2014

Member

No need to indent here.

Here is an example how to use `ModelImageCreator`:
>>> model_image_creator = MorphModelImageCreator('input_sherpa.cfg',
'../exposure.fits', psf_file='psf.json')

This comment has been minimized.

@cdeil

cdeil Jan 29, 2014

Member

I think you need to add ... line continuation prompt here.

Try producing the docs and you will get warnings and errors for such things:

python setup.py build_sphinx
@cdeil

This comment has been minimized.

Member

cdeil commented Jan 29, 2014

A gammapy/morphology/tests/test_model.py file should be added.
Just having the file and adding import ..model is good to have as a starting point if there is no time to add tests now.

@cdeil

This comment has been minimized.

Member

cdeil commented Jan 29, 2014

This is a great contribution, thanks!
I'll do the small fixes mentioned above in master tomorrow.

cdeil added a commit that referenced this pull request Jan 29, 2014

Merge pull request #65 from adonath/model_image_creation
Creation of model images and image measurements

@cdeil cdeil merged commit b0321d8 into gammapy:master Jan 29, 2014

1 check failed

default The Travis CI build failed
Details

@cdeil cdeil changed the title from Creation of model images and image measurements to Add model image and image measurement functionality Apr 8, 2015

@cdeil cdeil added the feature label Apr 8, 2015

@cdeil cdeil added this to the 0.1 milestone Apr 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment