New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add up- and downsampling to SkyImage #653

Merged
merged 10 commits into from Jul 29, 2016

Conversation

Projects
None yet
2 participants
@adonath
Member

adonath commented Jul 28, 2016

This PR adds the up- and downsampling to SkyImage and makes the following related changes:

  • Add SkyImage.upsample() and SkyImage.downsample() methods and tests
  • Modify SkyImage.pad() to take an additional shape parameter and recompute the wcs specs.
  • Add a SkyImage.crop() method to crop a skyimage and recompute the wcs specs.
  • Make compute_ts_map and compute_ts_map_multiscale work with SkyImage and SkyImageCollection

@cdeil cdeil added this to the 0.5 milestone Jul 28, 2016

@cdeil cdeil self-assigned this Jul 28, 2016

Show outdated Hide outdated gammapy/image/core.py
Show outdated Hide outdated gammapy/image/core.py
Show outdated Hide outdated gammapy/image/core.py
Show outdated Hide outdated gammapy/image/core.py
Show outdated Hide outdated gammapy/image/core.py
Show outdated Hide outdated gammapy/image/core.py
@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Jul 28, 2016

Member

I had another quick look. All looks good to me now. Thanks!

Member

cdeil commented Jul 28, 2016

I had another quick look. All looks good to me now. Thanks!

@adonath

This comment has been minimized.

Show comment
Hide comment
@adonath

adonath Jul 28, 2016

Member

Thanks @cdeil! I've changed SkyImage.pad() and SkyImage.crop() as we discussed offline. I moved the shape computing utility functions to gammapy.utils.array, to keep the namespace in gammapy.image cleaner.

Member

adonath commented Jul 28, 2016

Thanks @cdeil! I've changed SkyImage.pad() and SkyImage.crop() as we discussed offline. I moved the shape computing utility functions to gammapy.utils.array, to keep the namespace in gammapy.image cleaner.

Show outdated Hide outdated gammapy/image/core.py
@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Jul 28, 2016

Member

Missing @requires_dependency('scipy') and @requires_dependency('skimage') for the up and downsample tests: https://travis-ci.org/gammapy/gammapy/jobs/148055171#L1507

Member

cdeil commented Jul 28, 2016

Missing @requires_dependency('scipy') and @requires_dependency('skimage') for the up and downsample tests: https://travis-ci.org/gammapy/gammapy/jobs/148055171#L1507

@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Jul 29, 2016

Member

@adonath - Thanks!

pytest skips should be OK. I'm merging this now.

Member

cdeil commented Jul 29, 2016

@adonath - Thanks!

pytest skips should be OK. I'm merging this now.

@cdeil cdeil merged commit 2532a37 into gammapy:master Jul 29, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment