New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image measure methods #67

Merged
merged 4 commits into from Feb 9, 2014

Conversation

Projects
None yet
2 participants
@adonath
Member

adonath commented Feb 8, 2014

Added containment fraction and containment radius functions, which work on regular image data. Modified compute_image_moments to return also the 0th moment and to include a pixel shift, if necessary, because there are different pixel conventions.

@adonath

This comment has been minimized.

Show comment
Hide comment
@adonath

adonath Feb 8, 2014

Member

Is it OK to include also PR #66? Because I don't want to rebase... It should work if the PRs are merged in the right order, or not? A third PR will follow in a few minutes...

Member

adonath commented Feb 8, 2014

Is it OK to include also PR #66? Because I don't want to rebase... It should work if the PRs are merged in the right order, or not? A third PR will follow in a few minutes...

@adonath

This comment has been minimized.

Show comment
Hide comment
@adonath

adonath Feb 8, 2014

Member

I added the computation of moments of a sum of gaussian sources to this PR. No third PR...

Member

adonath commented Feb 8, 2014

I added the computation of moments of a sum of gaussian sources to this PR. No third PR...

cdeil added a commit that referenced this pull request Feb 9, 2014

@cdeil cdeil merged commit 9f89b25 into gammapy:master Feb 9, 2014

1 check passed

default The Travis CI build passed
Details
@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Feb 9, 2014

Member

Thanks!

Member

cdeil commented Feb 9, 2014

Thanks!

@adonath adonath deleted the adonath:add_image_measure_methods branch Jun 10, 2014

cdeil pushed a commit to cdeil/gammapy that referenced this pull request Jul 18, 2014

Merge pull request gammapy#67 from wkerzendorf/manifest_outdated
removed setuptools_bootstrap.py as it doesn't exist any more

@cdeil cdeil added the feature label Apr 8, 2015

@cdeil cdeil added this to the 0.1 milestone Apr 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment