New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate PyFACT functionality in Gammapy #68

Merged
merged 34 commits into from Feb 17, 2014

Conversation

Projects
None yet
2 participants
@cdeil
Member

cdeil commented Feb 12, 2014

This PR integrates the PyFACT functionality I find useful into gammapy.
Some things are heavily re-written (use astropy, clean up API or implementation, restructure), it's not a 1:1 translation.

  • Add a note giving credit to PyFACT
  • Convert map.py content
  • Convert tools.py content
  • Convert pfmap.py script
  • Convert pfsim.py script
  • Convert pfspec.py script
  • Convert cta_response_root2fits.py content
  • Convert docs

There's much more to do, but I want to merge this now, so I've created a new issue to continue with the PyFACT -> gammapy integration in the future: #78

@cdeil cdeil added this to the 0.1 milestone Feb 11, 2014

@cdeil cdeil added the enhancement label Feb 11, 2014

@cdeil cdeil self-assigned this Feb 11, 2014

@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil
Member

cdeil commented Feb 12, 2014

@cdeil cdeil referenced this pull request Feb 17, 2014

Closed

Integrate PyFACT functionality in gammapy #78

2 of 10 tasks complete

@cdeil cdeil assigned ellisowen and cdeil and unassigned cdeil and ellisowen Feb 17, 2014

cdeil added a commit that referenced this pull request Feb 17, 2014

Merge pull request #68 from cdeil/issue_68
Integrate PyFACT functionality in gammapy

@cdeil cdeil merged commit 396d21f into gammapy:master Feb 17, 2014

1 check was pending

default The Travis CI build is in progress
Details

@cdeil cdeil deleted the cdeil:issue_68 branch May 30, 2014

@cdeil cdeil changed the title from Integrate PyFACT functionality in gammapy to Integrate PyFACT functionality in Gammapy Apr 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment