New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc image and cube cleanup #710

Merged
merged 24 commits into from Sep 20, 2016

Conversation

Projects
None yet
1 participant
@cdeil
Member

cdeil commented Sep 19, 2016

This PR does misc cleanup and removal of old stuff from Gammapy:

  • Remove gammapy.image.utils.dict_to_hdulist
  • Remove gammapy.image.atrous_image
  • Remove gammapy.image.threshold function (is available on SkyImage)
  • Make gammapy.image.compute_binning private
  • Remove gammapy-image-coordinates
  • Remove gammapy.image.images_to_cube
  • Add getting started to gammapy.cube docs (and minor SkyCube fixes)
  • Split SkyImage.fill into more explicit fill_events (the case of self.data.fill(value) has been removed, that's just an operation on the numpy array self.data). Remove gammapy.image.wcs_histogram2d, put the implementation into SkyImage.fill_events.
  • Rename SkyCube.fill to SkyCube.fill_events, re-implement the filling implementation and add tests.

... any more stuff ... see the commits.
(I'm realising that I'm basically manually re-listing the commits here, which isn't helpful.)

@cdeil cdeil added the cleanup label Sep 19, 2016

@cdeil cdeil added this to the 0.5 milestone Sep 19, 2016

@cdeil cdeil self-assigned this Sep 19, 2016

@cdeil cdeil changed the title from Misc cleanup to Misc image and cube cleanup Sep 19, 2016

@cdeil cdeil merged commit 2491871 into gammapy:master Sep 20, 2016

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment