New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image asmooth algorithm #746

Merged
merged 4 commits into from Nov 2, 2016

Conversation

Projects
None yet
2 participants
@adonath
Member

adonath commented Oct 28, 2016

This PR implements the asmooth algorithm as requested in #99. The algorithm is described in http://arxiv.org/pdf/astro-ph/0601306v1.pdf. I don't have much time to improve the implementation right now, but I'd still like merge it, because it's been laying around on my hard disk forever. I'll open issues to add docs, examples (I'm thinking of reproducing Fig. 1&5 of the 2FHL paper) and missing features (internal background estimation, as described in the paper), as soon as this PR is merged.

@adonath adonath added the feature label Oct 28, 2016

@adonath adonath added this to the 0.5 milestone Oct 28, 2016

@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Oct 31, 2016

Member

Thanks!

+1 to merge this now and make a new issue with a task list.

For the reference I'd suggest to put a link to ADS instead of the PDF on arXiv: http://adsabs.harvard.edu/abs/2006MNRAS.368...65E
That's what we do everywhere else (or should IMO).

Do you have the image from the 2FHL paper as FITS for checking?
If no, I could just ask the corresponding author if he'll give it to us for testing.
That's what I did for the 2FHL event list, and there was no problem.
I could just send another email in that thread from a year ago.

Member

cdeil commented Oct 31, 2016

Thanks!

+1 to merge this now and make a new issue with a task list.

For the reference I'd suggest to put a link to ADS instead of the PDF on arXiv: http://adsabs.harvard.edu/abs/2006MNRAS.368...65E
That's what we do everywhere else (or should IMO).

Do you have the image from the 2FHL paper as FITS for checking?
If no, I could just ask the corresponding author if he'll give it to us for testing.
That's what I did for the 2FHL event list, and there was no problem.
I could just send another email in that thread from a year ago.

@adonath

This comment has been minimized.

Show comment
Hide comment
@adonath

adonath Nov 2, 2016

Member

Travis-CI passes except for #750. So I'm merging this now...

Member

adonath commented Nov 2, 2016

Travis-CI passes except for #750. So I'm merging this now...

@adonath adonath merged commit 9ee66d3 into gammapy:master Nov 2, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@adonath adonath deleted the adonath:asmooth_algorithm branch Nov 2, 2016

@adonath adonath referenced this pull request Nov 14, 2016

Closed

Implement ASMOOTH #99

@bsipocz bsipocz referenced this pull request Nov 16, 2016

Merged

Fix RTD pdf build #779

@cdeil cdeil changed the title from Implement asmooth algorithm to Add image asmooth algorithm Nov 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment