Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image asmooth algorithm #746

Merged
merged 4 commits into from Nov 2, 2016
Merged

Add image asmooth algorithm #746

merged 4 commits into from Nov 2, 2016

Conversation

@adonath
Copy link
Member

@adonath adonath commented Oct 28, 2016

This PR implements the asmooth algorithm as requested in #99. The algorithm is described in http://arxiv.org/pdf/astro-ph/0601306v1.pdf. I don't have much time to improve the implementation right now, but I'd still like merge it, because it's been laying around on my hard disk forever. I'll open issues to add docs, examples (I'm thinking of reproducing Fig. 1&5 of the 2FHL paper) and missing features (internal background estimation, as described in the paper), as soon as this PR is merged.

@adonath adonath added this to the 0.5 milestone Oct 28, 2016
@cdeil
Copy link
Member

@cdeil cdeil commented Oct 31, 2016

Thanks!

+1 to merge this now and make a new issue with a task list.

For the reference I'd suggest to put a link to ADS instead of the PDF on arXiv: http://adsabs.harvard.edu/abs/2006MNRAS.368...65E
That's what we do everywhere else (or should IMO).

Do you have the image from the 2FHL paper as FITS for checking?
If no, I could just ask the corresponding author if he'll give it to us for testing.
That's what I did for the 2FHL event list, and there was no problem.
I could just send another email in that thread from a year ago.

@adonath adonath force-pushed the adonath:asmooth_algorithm branch from d7a9a9f to b5ec3d8 Nov 1, 2016
@adonath adonath force-pushed the adonath:asmooth_algorithm branch 2 times, most recently from b1ca43c to 57ae8a9 Nov 1, 2016
@adonath adonath force-pushed the adonath:asmooth_algorithm branch from 57ae8a9 to e145634 Nov 2, 2016
@adonath
Copy link
Member Author

@adonath adonath commented Nov 2, 2016

Travis-CI passes except for #750. So I'm merging this now...

@adonath adonath merged commit 9ee66d3 into gammapy:master Nov 2, 2016
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@adonath adonath deleted the adonath:asmooth_algorithm branch Nov 2, 2016
@adonath adonath mentioned this pull request Nov 14, 2016
@bsipocz bsipocz mentioned this pull request Nov 16, 2016
@cdeil cdeil changed the title Implement asmooth algorithm Add image asmooth algorithm Nov 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants