New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TablePSFChecker #763

Merged
merged 1 commit into from Nov 10, 2016

Conversation

Projects
None yet
2 participants
@dltiziani
Contributor

dltiziani commented Nov 10, 2016

A script for testing the table PSF is added.
The following checks are implemented:

  • NaN entries within safe energy threshold?
  • integral of PSF equals 1?
  • relative difference of containment radii of neighboring energy/offset bins exceeds a threshold?

@cdeil cdeil added the feature label Nov 10, 2016

@cdeil cdeil added this to the 0.5 milestone Nov 10, 2016

@cdeil cdeil self-assigned this Nov 10, 2016

@cdeil cdeil changed the title from Table PSF check script to Add TablePSFChecker Nov 10, 2016

@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Nov 10, 2016

Member

@dltiziani - Thanks!

This will need tests and also docs / code improvements.

But it's better to have this available for everyone in master, and do those in future PRs whenever someone has time. So I'm merging this now.

Member

cdeil commented Nov 10, 2016

@dltiziani - Thanks!

This will need tests and also docs / code improvements.

But it's better to have this available for everyone in master, and do those in future PRs whenever someone has time. So I'm merging this now.

@cdeil cdeil merged commit c5a856d into gammapy:master Nov 10, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cdeil cdeil referenced this pull request Nov 10, 2016

Merged

Improve PSF checker and add a test #767

5 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment