Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PSF checker and add a test #767

Merged
merged 2 commits into from Nov 11, 2016
Merged

Improve PSF checker and add a test #767

merged 2 commits into from Nov 11, 2016

Conversation

@cdeil
Copy link
Member

@cdeil cdeil commented Nov 10, 2016

This pull request is a continuation of #763

  • Rename file and class
  • Add __all__ and import in gammapy/irf/__init__.py so that it's exposed and visible in the docs
  • Add global status summarising all checks to results dict
  • Misc improvements, e.g. how config options are handled, docstrings, ...
  • Add $GAMMAPY_EXTRA/datasets/hess-hap-hd-prod3/psf_table.fits.gz and a test for the PSF checker for one PSF.
@cdeil cdeil added this to the 0.5 milestone Nov 10, 2016
@cdeil cdeil self-assigned this Nov 10, 2016
@cdeil cdeil force-pushed the cdeil:psf-checker-test branch from c84d460 to 7bec5c4 Nov 11, 2016
@cdeil
Copy link
Member Author

@cdeil cdeil commented Nov 11, 2016

@dltiziani - FYI: Here's some improvements to the PSF checker class (and added docs / tests) and it's renamed and moved to a different file.

It will need further work to be useful, the Python for loops are very slow, and duplicate code that is already available in other PSF classes in Gammapy.

@cdeil cdeil force-pushed the cdeil:psf-checker-test branch from 7bec5c4 to d1bc618 Nov 11, 2016
@cdeil
Copy link
Member Author

@cdeil cdeil commented Nov 11, 2016

Travis-ci tests already passed on last build: https://travis-ci.org/gammapy/gammapy/builds/175014946
Merging this now.

@cdeil cdeil merged commit bf6bfc8 into gammapy:master Nov 11, 2016
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@cdeil cdeil mentioned this pull request May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant