Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add skyimage smooth method #774
I've left some inline comments. Probably establishing kernel normalisation via the test is the most important one.
PS: one thing I don't like about Astropy kernels is that they sometimes emit this warning:
WARNING:gammapy.detect.lima:Using weighted kernels can lead to biased results. WARNING: The kernel normalization factor is exceptionally large, > 100. [astropy.convolution.core] WARNING:astropy:The kernel normalization factor is exceptionally large, > 100.
This is currently present in our docs build, and should be silenced. Same here for
SkyImage.smooth, we never should emit that warning just because someone has a large kernel. So either not use Astropy kernel smooth, or catch and ignore the warning.