Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHA type II file I/O to SpectrumObservationList #783

Merged
merged 4 commits into from Nov 21, 2016

Conversation

@joleroi
Copy link
Contributor

@joleroi joleroi commented Nov 18, 2016

the PR

  • Add the class PHACountsSpectrumList for a list of on or off vectors
  • Add methods to read/write a SpectrumObservationList as PHA type II files

This is useful for simulations, e.g. when simulation many spectra with the same instrument response functions. The written files are at the moment not properly read by sherpa (background datasets are not detected automatically).

see https://heasarc.gsfc.nasa.gov/docs/heasarc/ofwg/docs/spectra/ogip_92_007/node8.html

@joleroi joleroi added this to the 0.6 milestone Nov 18, 2016
@joleroi joleroi force-pushed the joleroi:pha_typeII branch from 3a8bf15 to adada3b Nov 18, 2016
@joleroi joleroi force-pushed the joleroi:pha_typeII branch 2 times, most recently from 8a57955 to 33d3418 Nov 18, 2016
@joleroi joleroi force-pushed the joleroi:pha_typeII branch from 33d3418 to fe8a979 Nov 21, 2016
@joleroi joleroi merged commit 4d8c899 into gammapy:master Nov 21, 2016
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@joleroi joleroi deleted the joleroi:pha_typeII branch Nov 21, 2016
@cdeil cdeil modified the milestones: 0.5, 0.6 Nov 21, 2016
@cdeil cdeil changed the title Add read/write methods for PHA type II file to SpectrumObservationList Add PHA type II file I/O to SpectrumObservationList Nov 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants