Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SkyCube exposure computation #784

Merged
merged 2 commits into from Nov 22, 2016

Conversation

@JouvinLea
Copy link

@JouvinLea JouvinLea commented Nov 20, 2016

@adonath
This PR is just to change how you compute the exposure cube for offset > offset_max. As we discussed it's now 0.

@JouvinLea
Copy link
Author

@JouvinLea JouvinLea commented Nov 21, 2016

@adonath
I don't understand the issue on Travis?

@adonath adonath added the bug label Nov 21, 2016
@adonath adonath modified the milestones: 0.5, 0.6 Nov 21, 2016
@adonath adonath self-assigned this Nov 21, 2016
@adonath
Copy link
Member

@adonath adonath commented Nov 21, 2016

@JouvinLea Thanks! The fail on Travis-CI is not related to your changes.

Can you add an additional assert in gammapy/cube/tests/test_exposure.py, that checks if the exposure is really zero for offset > offset_max? Then it's ready to merge...

Lea Jouvin
@JouvinLea
Copy link
Author

@JouvinLea JouvinLea commented Nov 21, 2016

I added the test for offset > offset max and it passed can we merge now?

@cdeil cdeil changed the title Improve SKyExposureCube Improve exposure SkyCube computation Nov 22, 2016
@JouvinLea
Copy link
Author

@JouvinLea JouvinLea commented Nov 22, 2016

@adonath
Is it possible to merge? It's just I need that for my 3D analysis.... and I don't want to wait too long since then the rebase will be difficult...

@adonath adonath merged commit b334c2e into gammapy:master Nov 22, 2016
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adonath
Copy link
Member

@adonath adonath commented Nov 22, 2016

@JouvinLea Merged, Thanks!

@cdeil cdeil changed the title Improve exposure SkyCube computation Improve SkyCube exposure computation Dec 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants