Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix Wstat #789
There was a bug in
and the same one in
This PR fixes this and updates all examples and docs
Nov 21, 2016
@joleroi - Thanks!
@registerrier - Could you please review the WSTAT values for
@joleroi and @registerrier - Are Gammapy WSTAT results now consistent with XSPEC or Sherpa results? I think it would be good to know if that's the case, and either way add a note to the Gammapy docs page?
Yes they agree with Sherpa
For XSPEC we don't know, because we only have the implementation you added to
and we don't know if it's correct or not
@registerrier - My understanding is that Sherpa WSTAT is new and not very well tested / documented (see e.g. sherpa/sherpa#314).
But yes, if it's not easy to do with XSPEC, and our results are consistent with Sherpa and based on well-checked formulas, it's good enough. @registerrier - I was mainly pinging you to review the formulas and description in this docs section one last time (before WSTAT is ready for 1.0 and publication):