Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc fixes to spectrum fitting code #791

merged 5 commits into from Nov 22, 2016

Misc fixes to spectrum fitting code #791

merged 5 commits into from Nov 22, 2016


Copy link

@joleroi joleroi commented Nov 22, 2016

This PR

  • Reactivate the tests on SpectrumFit, they work with the Sherpa head version. Many values changed over the quite long time this test was inactive. It's impossible to track down which pull requests changed this. 馃槥

  • Always cast inputs to CountsSpectrum as Quantity with unit ct. Before more cases (numpy array, dimensionless quantity, quantity with unit counts) were supported, which lead to unwanted behaviour in some places

  • Resturctures the plot method on SpectrumFitResult

There will be a follow up PR, splitting out the test on SpectrumFitResult an make it independent from the test in SpectrumFitResult. It will also add functionality to display/debug stats per bin

@joleroi joleroi added this to the 0.6 milestone Nov 22, 2016
@joleroi joleroi self-assigned this Nov 22, 2016
@joleroi joleroi force-pushed the joleroi:misc_fixes branch from 2b79b3d to 8fa6ce7 Nov 22, 2016
@joleroi joleroi merged commit bfc35f6 into gammapy:master Nov 22, 2016
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
@joleroi joleroi deleted the joleroi:misc_fixes branch Nov 22, 2016
@cdeil cdeil changed the title Misc fixes Misc fixes to spectrum fitting code Dec 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant