Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve LogEnergyAxis object #796

Merged
merged 7 commits into from Nov 28, 2016
Merged

Improve LogEnergyAxis object #796

merged 7 commits into from Nov 28, 2016

Conversation

@adonath
Copy link
Member

@adonath adonath commented Nov 24, 2016

This PR addresses #787. It changes LogEnergyAxis to use scipy's RegularGridInterpolator, which allows extrapolation of pixel and energy values. This is needed for extrapolation of SkyCube objects

@adonath adonath added this to the 0.6 milestone Nov 24, 2016
@adonath adonath self-assigned this Nov 24, 2016
@cdeil
Copy link
Member

@cdeil cdeil commented Nov 24, 2016

@adonath - Thanks!

Does counts cube filling now work with arbitrary EBOUNDS?
Are energies below and above the energy range dropped?

Is there a simple test I can read that shows the answer to these two questions is "yes"?

@adonath adonath force-pushed the adonath:rework_energy_axis branch from 4ebcb96 to a1330e3 Nov 25, 2016
@adonath adonath force-pushed the adonath:rework_energy_axis branch from a1330e3 to 0761ce3 Nov 28, 2016
@adonath
Copy link
Member Author

@adonath adonath commented Nov 28, 2016

@cdeil I added an additional assert (see here) to show, that it gives the same result as EventList.select_energy().

@adonath adonath force-pushed the adonath:rework_energy_axis branch from 0761ce3 to a777ef6 Nov 28, 2016
@adonath adonath merged commit fccced9 into gammapy:master Nov 28, 2016
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adonath adonath deleted the adonath:rework_energy_axis branch Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants