New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve LogEnergyAxis object #796

Merged
merged 7 commits into from Nov 28, 2016

Conversation

Projects
None yet
2 participants
@adonath
Member

adonath commented Nov 24, 2016

This PR addresses #787. It changes LogEnergyAxis to use scipy's RegularGridInterpolator, which allows extrapolation of pixel and energy values. This is needed for extrapolation of SkyCube objects

@adonath adonath added the feature label Nov 24, 2016

@adonath adonath added this to the 0.6 milestone Nov 24, 2016

@adonath adonath self-assigned this Nov 24, 2016

@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Nov 24, 2016

Member

@adonath - Thanks!

Does counts cube filling now work with arbitrary EBOUNDS?
Are energies below and above the energy range dropped?

Is there a simple test I can read that shows the answer to these two questions is "yes"?

Member

cdeil commented Nov 24, 2016

@adonath - Thanks!

Does counts cube filling now work with arbitrary EBOUNDS?
Are energies below and above the energy range dropped?

Is there a simple test I can read that shows the answer to these two questions is "yes"?

@adonath

This comment has been minimized.

Show comment
Hide comment
@adonath

adonath Nov 28, 2016

Member

@cdeil I added an additional assert (see here) to show, that it gives the same result as EventList.select_energy().

Member

adonath commented Nov 28, 2016

@cdeil I added an additional assert (see here) to show, that it gives the same result as EventList.select_energy().

@adonath adonath merged commit fccced9 into gammapy:master Nov 28, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment